fix(pathname.ts): ssg dynamic routes #1197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1196
What is it?
Description
The issue comes from here: https://github.com/BuilderIO/qwik/blob/main/packages/qwik-city/utils/pathname.ts#L59
Using replace in this way, when the parameter is missing, results in a double
//
that is no longer normalized.I preferred to fix the
normalizePathname
function rather than thegetPathnameForDynamicRoute
, so as to avoid other similar situations.Use cases and why
When I run ssg with the following routes folder:
I expect in dist folder (using myId and an empty value for
id
:Instead, when the
id
parameter is empty, nested page is removed.Checklist: