-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSProj Update #5145
CSProj Update #5145
Conversation
73d41f6
to
e0a8258
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands at this point in time, this PR can successfully build and run lean, as well as run all of our tests.
Tested environments:
- Docker Container Mono based on foundation image
- Windows 10 VS
- Ubuntu 20.04 Mono
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Leaving a few minor comments
Let's update the PR description with a summary of the changes and tests performed
Rebase onto master
Rebase onto master part 2
35a3de2
to
35e33e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽 Reviews addressed, rebased onto master and included summary of changes in PR description
Description
Update all CSProj files to the new format
Includes:
packages.config
toPackageReference
-> Reduces work of managing packages to a single line per package in proj file.Microsoft.NET.Sdk
-> Moves us to .Net standard proj format, allowing us to target more frameworks in the future as well as cleans up project files significantly. This is the largest change by far as it impacts the entire structure of the proj files. Including removal of a lot of default settings to reduce clutter.Compile Remove
$(Configuration)
to further reduce clutter.$(NugetPackageRoot)
variable instead of relative pathing for specific dll finds. -> With the change to packages, the storage is no longer in ./packages, so we needed to have a dynamic path variable to address this.Microsoft.NET.Test.Sdk
allowing fordotnet test
as well as supporting testing in VS16 project (new version this PR moves us too)Related Issue
Closes #1686
Related to #452
Motivation and Context
To move forward with supporting dotnet core we need to update our project files to the new .net standards.
Requires Documentation Change
N/A
How Has This Been Tested?
*locally refers to windows 10 environment and cloud refers to QuantConnect.com
Types of changes
Checklist:
bug-<issue#>-<description>
orfeature-<issue#>-<description>