-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Linux AArch64 wheels natively without QEMU #13682
Conversation
GitHub Actions now provides Linux runner images on native arm64 hardware[^1], which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support. [^1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 12831073301Details
💛 - Coveralls |
We previously restricted the tests to a small subset of the suite because of runtime concerns with QEMU. Since we are now running natively, this removes the restriction, bringing Linux AArch64 in line with what we expect from a Tier 2 platform.
It's all good - Linux AArch64 passed all tests. After #13474, there's a high chance that we can promote Linux AArch64 to Tier 1 platform support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I'm excited to potentially promote linux aarc64 to tier 1 in 2.0. I think when we do decided to bump it up to tier 1 we should just add this runner to the tier 1 job definition to enable pgo etc since the config is now essentially the same as the normal ubuntu latest job. But for the time being keeping it separate to not enable pgo makes sense to me.
Yeah, I deliberately didn't move it have PGO in the build process here because I somewhat considered that a Tier 1 thing. |
* Build Linux AArch64 wheels natively without QEMU GitHub Actions now provides Linux runner images on native arm64 hardware[^1], which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support. [^1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ * Remove restriction on tests We previously restricted the tests to a small subset of the suite because of runtime concerns with QEMU. Since we are now running natively, this removes the restriction, bringing Linux AArch64 in line with what we expect from a Tier 2 platform. * Remove explicit architecture selection (cherry picked from commit 3150351) # Conflicts: # .github/workflows/wheels-build.yml
…13684) * Build Linux AArch64 wheels natively without QEMU (#13682) * Build Linux AArch64 wheels natively without QEMU GitHub Actions now provides Linux runner images on native arm64 hardware[^1], which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support. [^1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ * Remove restriction on tests We previously restricted the tests to a small subset of the suite because of runtime concerns with QEMU. Since we are now running natively, this removes the restriction, bringing Linux AArch64 in line with what we expect from a Tier 2 platform. * Remove explicit architecture selection (cherry picked from commit 3150351) # Conflicts: # .github/workflows/wheels-build.yml * Update .github/workflows/wheels-build.yml --------- Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
* Build Linux AArch64 wheels natively without QEMU GitHub Actions now provides Linux runner images on native arm64 hardware[^1], which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support. [^1]: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ * Remove restriction on tests We previously restricted the tests to a small subset of the suite because of runtime concerns with QEMU. Since we are now running natively, this removes the restriction, bringing Linux AArch64 in line with what we expect from a Tier 2 platform. * Remove explicit architecture selection
GitHub Actions now provides Linux runner images on native arm64 hardware1, which means we should be able to build the wheels natively, without requiring QEMU. This potentially paves the way (pending a more complete move of CI to GHA) for Linux on AArch64 to potentially gain Tier 1 platforma support.
Summary
Details and comments
Footnotes
https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/ ↩