update libkafka version to v2.3.0 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apptut
commented
Feb 5, 2024
apptut
commented
- 升级librdkafa版本为v2.3.0
- 添加编译sacl相关补充文档
- 修复build_dependencies boot库无法下载bug
- 修复./cxx/examples/build.sh无法运行bug
AlexStocks
reviewed
Feb 5, 2024
| @@ -1,7 +1,7 @@ | |||
| [submodule "cxx/thirdparts/librdkafka"] | |||
| path = cxx/thirdparts/librdkafka | |||
| url = https://github.com/edenhill/librdkafka.git | |||
| branch = 1.4.x | |||
|
|
|||
There was a problem hiding this comment.
不指定版本号吗？
librdkafka 的 branch 只有：1.4.x，没有 2.3.0，新的方式是使用tag: v2.3.0 ，但 git submodule 这里只允许使用branch，无法使用 tag = v2.3.0 这种方式。所以删除了banch = 1.4.x ，但使用 git submodule update --init --recursive 方式把 libradkafa 子模块默认的commit 已经切到了 v2.3.0 的commit上。即默认clone时，拉取下来的代码就在 v2.3.0 commit上，可验证。
There was a problem hiding this comment.
@AlexStocks 但我也有疑问是：不知道pr会不会对主项目执行有 git submodule update --init --recursive 的更新操作，否则确实merge过去
AlexStocks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.