Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup & refactor libqb #569

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Cleanup & refactor libqb #569

merged 5 commits into from
Nov 20, 2024

Conversation

a740g
Copy link
Contributor

@a740g a740g commented Nov 19, 2024

This one is simple.

  • Runs libqb and friends through clang-format.
  • Removes many redundant forward declarations in libqb.cpp and qbx.cpp.
  • Supresses some C++ compiler warnings.
  • Stops free()ing L->structure_base in qblist.cpp.

@a740g a740g added bug Something isn't working libqb-refactor Separating out libqb.cpp labels Nov 19, 2024
@a740g a740g self-assigned this Nov 19, 2024
mkilgore
mkilgore approved these changes Nov 19, 2024
View reviewed changes
internal/c/libqb/src/glut-message.h Outdated Show resolved Hide resolved
@a740g a740g merged commit 2906f09 into QB64-Phoenix-Edition:main Nov 20, 2024
4 checks passed
@a740g a740g deleted the cleanup-refactor branch November 20, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RhoSigma-QB64 RhoSigma-QB64 RhoSigma-QB64 approved these changes

@mkilgore mkilgore mkilgore approved these changes

@grymmjack grymmjack Awaiting requested review from grymmjack

@flukiluke flukiluke Awaiting requested review from flukiluke

@SteveMcNeill SteveMcNeill Awaiting requested review from SteveMcNeill

Assignees

@a740g a740g

Labels
bug Something isn't working libqb-refactor Separating out libqb.cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a740g @mkilgore @RhoSigma-QB64