Finalize $NOPREFIX deprecation #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the Discord discussion: - complete removal of $VIRTUALKEYBOARD - $MIDISOUNDFONT and $NOPREFIX throw errors instead of warnings - $UNSTABLE:MIDI warning kept, but reworded - created a Milestone for final code removal
RhoSigma-QB64
requested review from
grymmjack,
mkilgore,
flukiluke,
SteveMcNeill and
a740g
- removed obsolete $MIDISOUNDFONT tests - renamed files to reflect the new _MIDISOUNDBANK method - adapted console only midi test to use the new _MIDISOUNDBANK
a740g
approved these changes
Sep 27, 2024
- make sure the deprecation errors come before the errors caused by the deprecation - reworked syntax highlighter file and added missing keywords
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Discord discussion: