Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Codecov / Update coverage #3303

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Unpin Codecov / Update coverage #3303

merged 10 commits into from
Jul 8, 2024

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Jun 26, 2024

Fixes NA

Summary/Motivation:

We've been having lots of issues with codecov lately. This is an attempt to fix that.

Changes proposed in this PR:

  • Unpin 0.6.0 due to "caching issue" supposedly being resolved
  • Update codecov.yml format

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@joseph-sentry
Copy link

It looks like the Codecov uploads originating from Jenkins are what's messing with the tokenless upload.

I think the Jenkins job is mistakenly uploading coverage reports to the main branch. Tokenless currently requires that the branch name specified when uploading follow a specific format, more info here.

What's happening is that the Jenkins job is uploading to main, which means that Codecov pins the commit SHA being uploaded to being on main, and ineligible for tokenless uploads. Later, when the codecov-action tries to upload to that same commit sha, Codecov sees that it already exists and is on the main branch so tokenless is not allowed, despite the uploader trying to provide the correct branch name that is valid for tokenless.

Also it seems like the Jenkins job is using a very old version of the Codecov uploader, so I would suggest upgrading it to use the CLI, more info here.

@mrmundt
Copy link
Contributor Author

mrmundt commented Jun 28, 2024

It looks like the Codecov uploads originating from Jenkins are what's messing with the tokenless upload.

I think the Jenkins job is mistakenly uploading coverage reports to the main branch. Tokenless currently requires that the branch name specified when uploading follow a specific format, more info here.

What's happening is that the Jenkins job is uploading to main, which means that Codecov pins the commit SHA being uploaded to being on main, and ineligible for tokenless uploads. Later, when the codecov-action tries to upload to that same commit sha, Codecov sees that it already exists and is on the main branch so tokenless is not allowed, despite the uploader trying to provide the correct branch name that is valid for tokenless.

Also it seems like the Jenkins job is using a very old version of the Codecov uploader, so I would suggest upgrading it to use the CLI, more info here.

I attempted to install codecov-cli on our build machine, and I am getting strange errors. Question: Do you know what be causing this error?

$ codecovcli --version
Traceback (most recent call last):
  File "/packages/python/codecov-cli/0.7.2/bin/codecovcli", line 5, in <module>
    from codecov_cli.main import run
  File "/packages/python/codecov-cli/0.7.2/lib/python3.8/site-packages/codecov_cli/main.py", line 14, in <module>
    from codecov_cli.commands.process_test_results import process_test_results
  File "/packages/python/codecov-cli/0.7.2/lib/python3.8/site-packages/codecov_cli/commands/process_test_results.py", line 8, in <module>
    from test_results_parser import (
ModuleNotFoundError: No module named 'test_results_parser'

EDIT: One of the dependencies didn't install. My goodness. Okay, continuing to work on this...

@mrmundt mrmundt removed the AT: RETEST label Jul 3, 2024
@blnicho blnicho merged commit 53d5cad into Pyomo:main Jul 8, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants