Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appsi nl writer: better error message when all variables are fixed #2407

Merged
merged 1 commit into from
May 20, 2022
Merged

Appsi nl writer: better error message when all variables are fixed #2407

merged 1 commit into from
May 20, 2022

Conversation

michaelbynum
Copy link
Contributor

Changes proposed in this PR:

  • Appsi update: raise a useful error message when writing an nl file for a model where all variables are fixed.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2407 (d9fb55f) into main (0e3fe5a) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
+ Coverage   85.66%   85.90%   +0.23%     
==========================================
  Files         617      617              
  Lines       76180    76180              
==========================================
+ Hits        65262    65441     +179     
+ Misses      10918    10739     -179
Flag Coverage Δ
linux 82.63% <ø> (+<0.01%) ⬆️
osx 72.86% <ø> (ø)
other 82.83% <ø> (+0.22%) ⬆️
win 79.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/solvers/plugins/solvers/GUROBI.py 88.52% <0.00%> (+0.32%) ⬆️
pyomo/solvers/plugins/solvers/CBCplugin.py 82.87% <0.00%> (+0.73%) ⬆️
pyomo/common/download.py 91.96% <0.00%> (+0.89%) ⬆️
pyomo/opt/results/container.py 75.75% <0.00%> (+0.90%) ⬆️
pyomo/solvers/plugins/solvers/GLPK.py 83.48% <0.00%> (+1.17%) ⬆️
examples/pyomobook/test_book_examples.py 96.80% <0.00%> (+1.20%) ⬆️
pyomo/contrib/appsi/build.py 87.69% <0.00%> (+1.53%) ⬆️
pyomo/solvers/plugins/converter/glpsol.py 94.73% <0.00%> (+1.75%) ⬆️
pyomo/scripting/plugins/build_ext.py 71.73% <0.00%> (+2.17%) ⬆️
pyomo/common/getGSL.py 66.66% <0.00%> (+3.33%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e3fe5a...d9fb55f. Read the comment docs.

@blnicho blnicho merged commit 92b3c53 into Pyomo:main May 20, 2022
@michaelbynum michaelbynum deleted the nl_error branch July 6, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blnicho blnicho blnicho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelbynum @blnicho