Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: limit contourpy to <1.1, to avoid building win32 from source #680

Merged
merged 2 commits into from
Aug 22, 2023
Merged

CI: limit contourpy to <1.1, to avoid building win32 from source #680

merged 2 commits into from
Aug 22, 2023

Conversation

rgommers
Copy link
Member

As seen in gh-679, contourpy fails to build from source on 32-bit. This is fixable, it should build from source just fine. But we don't want to deal with that if we can avoid it. And contourpy 1.0.7 works just fine.

[skip actions]

@rgommers
CI: ensure use of wheels, to avoid building contourpy from source on …
bbf5bea 
…win32

As seen in PyWaveletsgh-679, contourpy fails to build from source on 32-bit.
This is fixable, it should build from source just fine. But
we don't want to deal with that if we can avoid it. And contourpy
1.0.7 works just fine.

Also drop wheel builds, that's doing twice the same.

[skip actions]
@rgommers
Copy link
Member Author

Some Cython 3.0 warnings, but those are not yet fixable, since there isn't a good replacement for this syntax:

  warning: pywt\_extensions\config.pxi:3:0: The 'DEF' statement is deprecated and will be removed in a future Cython version. Consider using global variables, constants, and in-place literals instead. See https://github.com/cython/cython/issues/4310
  warning: pywt\_extensions\_pywt.pxd:15:0: The 'IF' statement is deprecated and will be removed in a future Cython version. Consider using runtime conditions or C macros instead. See https://github.com/cython/cython/issues/4310
  warning: pywt\_extensions\config.pxi:3:0: The 'DEF' statement is deprecated and will be removed in a future Cython version. Consider using global variables, constants, and in-place literals instead. See https://github.com/cython/cython/issues/4310

@rgommers
Copy link
Member Author

That worked, it installs contourpy-1.0.7-cp38-cp38-win32.whl for 32-bit Python, rather than trying to build 1.1.0 from source.

These are also straightforward fixes, so I'll merge this as well to keep the ball rolling.

@rgommers rgommers merged commit 7b88a37 into PyWavelets:master Aug 22, 2023
@rgommers rgommers added this to the v1.5.0 milestone Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rgommers