-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for pyTorch 1.1 #552
fix for pyTorch 1.1 #552
Conversation
now the error is following but it seems not to be related to this module...
|
@Borda that’s a test tube error. maybe submit a quick PR there? |
well, I was confused because |
true. but test-tube is a subclass of summarywriter |
* min pytorch 1.2 * fix IterableDataset * upgrade torchvision * fix msg
@williamFalcon it seems that the fix helps for crashing, could you merge and release a new version https://circleci.com/workflow-run/e15c02ed-128b-4081-b283-ea6e2690fdb4 |
@Borda 0.7.4 pushed! |
@Borda looks like test-tube install has a bug. never mind, fixed it. |
What does this PR do?
Follow-up to #546 and #549 Fixes #491
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.