Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dirpath and filename parameter in ModelCheckpoint #4213

Merged
merged 29 commits into from
Oct 23, 2020
Merged

Add dirpath and filename parameter in ModelCheckpoint #4213

merged 29 commits into from
Oct 23, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 17, 2020 •
edited
Loading

What does this PR do?

Fixes #3583
Fixes #4168
Fixes #2042
Fixes #4012
maybe more...

TODO:

  • Update/Add test
  • Update docs

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Oct 17, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

Line 283:13: W503 line break before binary operator
Line 284:13: W503 line break before binary operator
Line 285:13: W503 line break before binary operator

Comment last updated at 2020-10-23 03:03:24 UTC

@mergify mergify bot requested a review from a team October 17, 2020 18:26
@codecov
Copy link

codecov bot commented Oct 17, 2020 •
edited
Loading

Codecov Report

Merging #4213 into master will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4213    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files         111     111            
  Lines        8675    8007   -668     
=======================================
- Hits         7712    7445   -267     
+ Misses        963     562   -401

@Borda Borda added the feature Is an improvement or enhancement label Oct 17, 2020
@rohitgr7 rohitgr7 added the checkpointing Related to checkpointing label Oct 17, 2020
@rohitgr7 rohitgr7 changed the title [WIP] Add dirpath and filename parameter in ModelCheckpoint [ci skip] Add dirpath and filename parameter in ModelCheckpoint [ci skip] Oct 17, 2020
@mergify mergify bot requested a review from a team October 18, 2020 15:04
@rohitgr7 rohitgr7 requested review from ydcjeff and lezwon October 18, 2020 20:07
@carmocca
Copy link
Contributor

I think this:
https://github.com/PyTorchLightning/pytorch-lightning/blob/19a2afb61a69bb7c9987ad860ca96a2f2b92f664/pytorch_lightning/callbacks/model_checkpoint.py#L322-L324
should be in __init_ckpt_dir

@mergify mergify bot requested a review from a team October 21, 2020 19:24
awaelchli
awaelchli reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like it.
Glad this will finally solve the "trailing slash" problem in the file path to distinguish file from folder.

CHANGELOG.md Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
tests/test_deprecated.py Show resolved Hide resolved
tests/checkpointing/test_model_checkpoint.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team October 21, 2020 19:54
@rohitgr7 rohitgr7 requested a review from awaelchli October 21, 2020 21:31
awaelchli
awaelchli approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failing gpu test comes from master and will be fixed in #4292

@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2020

This pull request is now in conflict... :(

Borda
Borda reviewed Oct 22, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Borda
Borda reviewed Oct 22, 2020
View reviewed changes
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
pytorch_lightning/callbacks/model_checkpoint.py Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 merged commit 4c7ebdc into master Oct 23, 2020
@rohitgr7 rohitgr7 deleted the feature/mc_filepath branch October 23, 2020 04:29
@awaelchli awaelchli mentioned this pull request Oct 25, 2020
Merged
@ozen ozen mentioned this pull request Oct 25, 2020
Closed
@ozen
Copy link
Contributor

ozen commented Oct 25, 2020

This does not fix #4012.

@rohitgr7 rohitgr7 mentioned this pull request Oct 29, 2020
Merged
1 task
@ethanwharris ethanwharris mentioned this pull request Mar 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca left review comments

@Borda Borda Borda left review comments

@ydcjeff ydcjeff ydcjeff approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@justusschock justusschock justusschock approved these changes

@awaelchli awaelchli awaelchli approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@lezwon lezwon Awaiting requested review from lezwon

@s-rog s-rog Awaiting requested review from s-rog

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
checkpointing Related to checkpointing feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:1.0.x