Added getstate/setstate method for torch.save serialization #4127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ditional Optional Typing to results object
Codecov Report
@@ Coverage Diff @@
## master #4127 +/- ##
=======================================
+ Coverage 89% 92% +3%
=======================================
Files 103 103
Lines 7781 7792 +11
=======================================
+ Hits 6919 7147 +228
+ Misses 862 645 -217 |
SeanNaren
changed the title
|
Hello @SeanNaren! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-13 20:22:57 UTC |
rohitgr7
reviewed
Oct 13, 2020
Borda
reviewed
Oct 13, 2020
Borda
requested changes
Oct 13, 2020
… epochs for speed
Borda
reviewed
Oct 13, 2020
|
|
||
|
|
||
| @pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine") | ||
| def test_model_torch_save_ddp_cuda(tmpdir): |
There was a problem hiding this comment.
seems like this guy is hanging...
awaelchli
reviewed
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4114 and Fixes #4120
Still requires test, and to see if there is a less verbose way to fix serialization in the accelerator class.
Also note that this will omit any additional state variables of accelerators that inherit from this; it assumes custom accelerator will override
__getstate__and__setstate__, or ensure that other objects are setup again.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃