-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overwrite & add test for model hooks #4010
Conversation
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-20 10:26:52 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4010 +/- ##
=======================================
Coverage 90% 90%
=======================================
Files 103 103
Lines 7863 8228 +365
=======================================
+ Hits 7064 7394 +330
- Misses 799 834 +35 |
7b99db3
to
24e0486
Compare
24e0486
to
80b4ab9
Compare
It fixes bug |
This pull request is now in conflict... :( |
80b4ab9
to
57a8b18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition !
@awaelchli lets merge this one and later redo to mocks? |
What does this PR do?
adding a test for checking ho Model hooks are called, Closes #4001
fixes falling checking the parent model does not have implement hooks such as
'on_validation_start'
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃