Skip tuner algorithms on fast dev #3903

SkafteNicki · 2020-10-06T14:44:35Z

What does this PR do?

Fixes #3241
Using fast_dev_run=True in combination with tuner algorithms currently give strange error messages. fast_dev_run=True is meant to see that trainer.fit() runs without errors, not the tuner algorithms.
This PR implements that if the users calls the tuner algorithms while fast_dev_run=True, the tuning will be skipped and a warning will be thrown.

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests?
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

tests/trainer/test_trainer_tricks.py

pep8speaks · 2020-10-07T05:56:20Z

Hello @SkafteNicki! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-09 18:37:45 UTC

codecov · 2020-10-07T06:17:46Z

Codecov Report

Merging #3903 (13fd648) into master (41c9bee) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3903   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         116     116           
  Lines        8831    8837    +6     
======================================
+ Hits         8232    8238    +6     
  Misses        599     599

mergify · 2020-10-07T11:29:05Z

This pull request is now in conflict... :(

mergify · 2020-10-07T18:52:26Z

This pull request is now in conflict... :(

pytorch_lightning/tuner/lr_finder.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

mergify · 2020-10-09T18:55:12Z

This pull request is now in conflict... :(

…t_dev

…ki/pytorch-lightning into skip_tuner_on_fast_dev

rohitgr7 · 2020-11-03T17:14:54Z

@SkafteNicki is this still relevant/required??

SkafteNicki · 2020-11-09T12:04:40Z

@rohitgr7 yes, it is still relevant, and it is probably ready merging

rohitgr7

Great. LGTM :)

tchaton

Great catch !

Borda

lgtm

* skip on fast dev * fix error * changelog * fix recursive issue * combine tests * pep8 * move logic to base funcs * fix mistake * Update pytorch_lightning/tuner/lr_finder.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * pep Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Nicki Skafte <nugginea@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: chaton <thomas@grid.ai> (cherry picked from commit 4f3160b)

This reverts commit 189ed25

* skip on fast dev * fix error * changelog * fix recursive issue * combine tests * pep8 * move logic to base funcs * fix mistake * Update pytorch_lightning/tuner/lr_finder.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * pep Co-authored-by: William Falcon <waf2107@columbia.edu> Co-authored-by: Nicki Skafte <nugginea@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: chaton <thomas@grid.ai>

SkafteNicki added 2 commits October 6, 2020 16:37

skip on fast dev

26cf61d

merge

ea8d4c4

mergify bot requested a review from a team October 6, 2020 14:45

SkafteNicki added 2 commits October 6, 2020 16:45

fix error

51b978a

changelog

3bdc99b

Borda added the feature Is an improvement or enhancement label Oct 6, 2020

Borda reviewed Oct 6, 2020

View reviewed changes

tests/trainer/test_trainer_tricks.py Outdated Show resolved Hide resolved

mergify bot requested a review from a team October 6, 2020 17:53

williamFalcon and others added 3 commits October 6, 2020 15:25

fix recursive issue

8d77184

combine tests

09c8945

pep8

07d2f8e

Merge branch 'master' into skip_tuner_on_fast_dev

97ca967

rohitgr7 reviewed Oct 8, 2020

View reviewed changes

pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved

mergify bot requested a review from a team October 8, 2020 17:58

SkafteNicki added 3 commits October 9, 2020 10:52

move logic to base funcs

d0bfab2

merge

c4f55c7

fix mistake

4e15745

rohitgr7 reviewed Oct 9, 2020

View reviewed changes

pytorch_lightning/tuner/lr_finder.py Outdated Show resolved Hide resolved

mergify bot requested a review from a team October 9, 2020 10:36

Update pytorch_lightning/tuner/lr_finder.py

dd94000

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

SkafteNicki added 2 commits October 14, 2020 13:09

Merge remote-tracking branch 'upstream/master' into skip_tuner_on_fas…

f648fe3

…t_dev

Merge branch 'skip_tuner_on_fast_dev' of https://github.com/SkafteNic…

3077ad4

…ki/pytorch-lightning into skip_tuner_on_fast_dev

Borda added this to the 1.0.x milestone Oct 20, 2020

edenlightning modified the milestones: 1.0.3, 1.1 Oct 20, 2020

stale bot removed the won't fix This will not be worked on label Nov 3, 2020

Merge branch 'master' into skip_tuner_on_fast_dev

2b6d524

rohitgr7 requested review from ananyahjha93, awaelchli, justusschock, nateraw, SeanNaren, tchaton, teddykoker and williamFalcon as code owners November 3, 2020 17:16

pep

8deadad

SkafteNicki added 3 commits November 9, 2020 13:08

merge

6a9a42f

merge

4c19e12

Merge branch 'master' into skip_tuner_on_fast_dev

e0d3b89

rohitgr7 approved these changes Nov 9, 2020

View reviewed changes

tchaton approved these changes Nov 9, 2020

View reviewed changes

Merge branch 'master' into skip_tuner_on_fast_dev

13fd648

Borda approved these changes Nov 9, 2020

View reviewed changes

Borda merged commit 4f3160b into Lightning-AI:master Nov 9, 2020

Borda modified the milestones: 1.1, 1.0.x Nov 9, 2020

SeanNaren pushed a commit that referenced this pull request Nov 11, 2020

Revert "Skip tuner algorithms on fast dev (#3903)"

7625e49

This reverts commit 189ed25

SkafteNicki deleted the skip_tuner_on_fast_dev branch December 30, 2020 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Skip tuner algorithms on fast dev #3903

Skip tuner algorithms on fast dev #3903

SkafteNicki commented Oct 6, 2020

pep8speaks commented Oct 7, 2020 •

edited

Loading

codecov bot commented Oct 7, 2020 •

edited

Loading

mergify bot commented Oct 7, 2020

mergify bot commented Oct 7, 2020

mergify bot commented Oct 9, 2020

rohitgr7 commented Nov 3, 2020

SkafteNicki commented Nov 9, 2020

rohitgr7 left a comment

tchaton left a comment

Borda left a comment

Skip tuner algorithms on fast dev #3903

Skip tuner algorithms on fast dev #3903

Conversation

SkafteNicki commented Oct 6, 2020

What does this PR do?

Before submitting

PR review

Did you have fun?

pep8speaks commented Oct 7, 2020 • edited Loading

Comment last updated at 2020-11-09 18:37:45 UTC

codecov bot commented Oct 7, 2020 • edited Loading

Codecov Report

mergify bot commented Oct 7, 2020

mergify bot commented Oct 7, 2020

mergify bot commented Oct 9, 2020

rohitgr7 commented Nov 3, 2020

SkafteNicki commented Nov 9, 2020

rohitgr7 left a comment

Choose a reason for hiding this comment

tchaton left a comment

Choose a reason for hiding this comment

Borda left a comment

Choose a reason for hiding this comment

pep8speaks commented Oct 7, 2020 •

edited

Loading

codecov bot commented Oct 7, 2020 •

edited

Loading