-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up optimizer code #3587
Clean up optimizer code #3587
Conversation
This pull request is now in conflict... :( |
Hi @carmocca! Mind rebasing your PR? |
Hello @carmocca! Thanks for updating this PR.
Comment last updated at 2020-10-21 18:08:24 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3587 +/- ##
=======================================
- Coverage 93% 91% -2%
=======================================
Files 103 103
Lines 7847 8041 +194
=======================================
+ Hits 7282 7333 +51
- Misses 565 708 +143 |
@edenlightning @Borda rebased, unblocked and ready to review! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
OptimizerConnector
logic to avoid duplicated code.lr_scheduler
dict. Adds a test for this warning.init_optimizers
function soconfigure_optimizers
is only called at the end.([optimizer], scheduler)
,trainer.optimizers
became[optimizer, scheduler]
configure_optimizers
returns. Adds a test for this exception.strict
.lr_scheduler
dict. Adds a test for this warning.ReduceLROnPlateau
scheduler is used. both in the case of{"optimizer": optimizer, "lr_scheduler": scheduler, "monitor": "your_loss"}
and{"optimizer": optimizer, "lr_scheduler": {"scheduler": scheduler, "monitor": "your_loss"}}
. Adds tests for these exceptions.val_loss
.No issue to tag. Just some stuff I found while coding #3586
Before submitting