use fsspec instead of gfile for all IO #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
======================================
Coverage 90% 90%
======================================
Files 90 90
Lines 8158 8138 -20
======================================
- Hits 7362 7349 -13
+ Misses 796 789 -7 |
Borda
added
feature
ydcjeff
reviewed
Sep 2, 2020
This better supports remote (and local) file operations with a dedicated package
f4hy
changed the title
justusschock
approved these changes
Sep 3, 2020
Co-authored-by: Justus Schock <12886177+justusschock@users.noreply.github.com>
Borda
approved these changes
Sep 3, 2020
| @@ -7,3 +7,4 @@ future>=0.17.1 # required for builtins in setup.py | |||
| # pyyaml>=3.13 | |||
| PyYAML>=5.1 # OmegaConf requirement >=5.1 | |||
| tqdm>=4.41.0 | |||
| fsspec>=0.8.0 | |||
There was a problem hiding this comment.
is this a minimal or this was just you are using?
There was a problem hiding this comment.
Ah ya, that was just the version I tested on. I think this will work for my purposes as early as 0.6. We can relax this.
Borda
changed the title
ydcjeff
approved these changes
Sep 3, 2020
7 tasks
Borda
added a commit
that referenced
this pull request
Sep 18, 2020
* Fix ModelCheckpoint's name formatting * Fix failing tests * Add dot to CHECKPOINT_SUFFIX * Set variables to their default values at the end of tests * Fix logic for filepath='' and filename=None. Add test * Fix Windows tests * Fix typo. Remove leading line break and zeroes * Remove CHECKPOINT_SUFFIX * Fix typos. Use appropriate f-string format * Apply suggestions from code review * Fix broken tests after #3320 * Finish changes suggested by Borda * Use explicit test var names * Apply suggestions Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Apply suggestions Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update CHANGELOG * Apply suggestions from code review * for * prepend whitespace in warn msg Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This better supports remote (and local) file operations with a dedicated package.
Fixes #3242
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃