Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: Remote Logging with Tensorboard #3236

Merged
merged 4 commits into from
Aug 28, 2020
Merged

Bug Fix: Remote Logging with Tensorboard #3236

merged 4 commits into from
Aug 28, 2020

Conversation

XDynames
Copy link
Contributor

@XDynames XDynames commented Aug 28, 2020 •
edited
Loading

#What does this PR do?
Fixes logging to a google cloud service bucket with tensorboard

Bug Fixes:

  • When saving hyperparameters to yaml previously standard library open was used instead of the cloud_open wrapper from utilities causing remote paths to fail
  • When tensorboard retrieves the current version number it would leave a terminal '/' which would through an invalid string to integer conversion -> Added .replace('/', '') to remove any remaining / tokens from the split

Fixes # 3237

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 28, 2020 00:46
@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #3236 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3236   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          85      85           
  Lines        8060    8104   +44     
======================================
+ Hits         7271    7282   +11     
- Misses        789     822   +33

@Borda Borda added the bug Something isn't working label Aug 28, 2020
@mergify mergify bot requested a review from a team August 28, 2020 07:38
@williamFalcon williamFalcon merged commit 79375e6 into Lightning-AI:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XDynames @Borda @williamFalcon