Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support limit_mode_batches (int) for infinite dataloader #2840

Merged
merged 23 commits into from
Aug 7, 2020
Merged

Support limit_mode_batches (int) for infinite dataloader #2840

merged 23 commits into from
Aug 7, 2020

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Aug 5, 2020

What does this PR do?

Update of #2787

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 5, 2020 20:52
@rohitgr7 rohitgr7 marked this pull request as ready for review August 5, 2020 21:23
@rohitgr7 rohitgr7 changed the title Support limit_mode_batches (int) for infinite dataloader [WIP] Support limit_mode_batches (int) for infinite dataloader Aug 5, 2020
@mergify
Copy link
Contributor

mergify bot commented Aug 6, 2020

This pull request is now in conflict... :(

@rohitgr7 rohitgr7 force-pushed the fix_limit_batches_infdl branch from 9e809d2 to cf3935c Compare August 6, 2020 17:29
@codecov
Copy link

codecov bot commented Aug 6, 2020 •
edited
Loading

Codecov Report

Merging #2840 into master will increase coverage by 0%.
The diff coverage is 95%.

@@          Coverage Diff           @@
##           master   #2840   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          79      79           
  Lines        7228    7262   +34     
======================================
+ Hits         6522    6556   +34     
  Misses        706     706

@rohitgr7 rohitgr7 changed the title [WIP] Support limit_mode_batches (int) for infinite dataloader Support limit_mode_batches (int) for infinite dataloader Aug 6, 2020
@Borda
Copy link
Member

Borda commented Aug 6, 2020

@rohitgr7 is it still wip or ready to review?

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Aug 6, 2020 •
edited
Loading

@Borda ready!

@Borda Borda added this to the 0.9.0 milestone Aug 6, 2020
@Borda Borda requested review from awaelchli and Borda August 6, 2020 19:05
Borda
Borda approved these changes Aug 6, 2020
View reviewed changes
tests/trainer/test_dataloaders.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team August 6, 2020 19:16
@Borda Borda added allowed_pre_1.0 feature Is an improvement or enhancement ready PRs ready to be merged labels Aug 6, 2020
@mergify mergify bot requested a review from a team August 7, 2020 06:36
@mergify
Copy link
Contributor

mergify bot commented Aug 7, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the fix_limit_batches_infdl branch from c76b23e to 6941852 Compare August 7, 2020 07:38
@pep8speaks
Copy link

pep8speaks commented Aug 7, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

Line 263:120: E501 line too long (120 > 119 characters)

Comment last updated at 2020-08-07 07:40:24 UTC

@Borda Borda force-pushed the fix_limit_batches_infdl branch from 6941852 to 7a3d115 Compare August 7, 2020 07:40
@mergify mergify bot requested a review from a team August 7, 2020 09:18
@Borda Borda merged commit a642349 into master Aug 7, 2020
@Borda Borda deleted the fix_limit_batches_infdl branch August 7, 2020 11:02
awaelchli
awaelchli reviewed Aug 7, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @rohitgr7, really great to see these edge cases getting fixed!

@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Aug 7, 2020

Thanks @awaelchli ✌️

@Borda Borda modified the milestones: 0.9.0, 1.0.0 Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli left review comments

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@justusschock justusschock justusschock approved these changes

Assignees
No one assigned
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.9
Development

Successfully merging this pull request may close these issues.
6 participants
@rohitgr7 @Borda @pep8speaks @awaelchli @justusschock @SkafteNicki