Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setup call while testing #2624

Merged
merged 7 commits into from
Jul 25, 2020
Merged

fix setup call while testing #2624

merged 7 commits into from
Jul 25, 2020

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #2620

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team July 16, 2020 19:19
@codecov
Copy link

codecov bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #2624 into master will decrease coverage by 0%.
The diff coverage is 86%.

@@          Coverage Diff           @@
##           master   #2624   +/-   ##
======================================
- Coverage      91%     91%   -0%     
======================================
  Files          70      70           
  Lines        5778    5776    -2     
======================================
- Hits         5270    5268    -2     
  Misses        508     508

@mergify mergify bot requested a review from a team July 16, 2020 19:47
@rohitgr7 rohitgr7 changed the title fix setup call while testing [WIP] fix setup call while testing Jul 16, 2020
@Borda Borda added bug Something isn't working feature Is an improvement or enhancement labels Jul 17, 2020
@rohitgr7 rohitgr7 changed the title [WIP] fix setup call while testing fix setup call while testing Jul 18, 2020
@rohitgr7 rohitgr7 requested review from williamFalcon and removed request for a team July 19, 2020 07:33
@mergify mergify bot requested a review from a team July 19, 2020 07:33
jeremyjordan
jeremyjordan suggested changes Jul 19, 2020
View reviewed changes
Copy link
Contributor

@jeremyjordan jeremyjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple things:

@mergify mergify bot requested a review from a team July 19, 2020 16:37
@rohitgr7 rohitgr7 requested review from jeremyjordan and removed request for a team July 19, 2020 17:30
@mergify mergify bot requested a review from a team July 19, 2020 17:31
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2020

This pull request is now in conflict... :(

@williamFalcon williamFalcon added allowed_pre_1.0 ready PRs ready to be merged labels Jul 23, 2020
@williamFalcon williamFalcon merged commit cb0c6ad into Lightning-AI:master Jul 25, 2020
@rohitgr7 rohitgr7 mentioned this pull request Jul 26, 2020
Closed
@rohitgr7 rohitgr7 deleted the fix_setup_call branch August 4, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli left review comments

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

Assignees
No one assigned
Labels
bug Something isn't working feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only invoke setup() once, not in both trainer.fit() and trainer.test()
5 participants
@rohitgr7 @williamFalcon @awaelchli @jeremyjordan @Borda