Fix lost compatibility with custom datatypes implementing .to
#2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2335 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 70 70
Lines 5512 5519 +7
======================================
+ Hits 4851 4857 +6
- Misses 661 662 +1 |
awaelchli
commented
Jun 23, 2020
| @@ -38,14 +39,43 @@ def apply_to_collection(data: Any, dtype: Union[type, tuple], function: Callable | |||
| return data | |||
|
|
|||
|
|
|||
| class TransferableDataType(ABC): | |||
There was a problem hiding this comment.
in case someone has a suggestion for a better name, let me know :)
|
nice! great catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2314
When I refactored the data transfer and added a model hook in #1756, I accidentally removed the ability to move non-tensor datastructures that implement
.to(). This PR re-enables that via a duck typing check. For this type of data, the user is not required to override the hook, since PL can handle this out of the box now.The test alone fails on master, confirming that the changes here fix the bug.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃