Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/lr finder #1676

Merged
merged 7 commits into from
May 4, 2020
Merged

Bugfix/lr finder #1676

merged 7 commits into from
May 4, 2020

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 30, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1648 where the learning rate finder could not be used by users that prefer to pass val_dataloaders directly to the different methods.

Fixed #1650 where the learning rate finder could not be used, when a EarlyStopping callback is passed to trainer.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 30, 2020 14:21
@Borda Borda added the bug Something isn't working label Apr 30, 2020
@Borda Borda added this to the 0.7.6 milestone Apr 30, 2020
@mergify mergify bot requested a review from a team April 30, 2020 16:18
@Borda Borda added the ready PRs ready to be merged label Apr 30, 2020
@Borda Borda requested review from awaelchli and jeremyjordan April 30, 2020 19:32
awaelchli
awaelchli approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok :)
What I forgot to ask in the original PR for the LR finder: Isn't the dumping and restoring of Trainer args a bit fragile? If we introduce new Trainer args that interfere with the LRFinder, we always have to remember adding them here for dumping and restoring? Otherwise it will introduce a bug. Or do I misunderstand the purpose?

@mergify mergify bot requested a review from a team April 30, 2020 20:19
@hirune924 hirune924 mentioned this pull request May 1, 2020
Closed
@SkafteNicki
Copy link
Member Author

The idea behind dumping and restoring trainer args is to take advantage of fit during the learning rate search (alternative would be to write a new training loop). I agree that this is a fragile feature, however for me the clear advantages of calling fit internally outweigh these disadvantages

@mergify
Copy link
Contributor

mergify bot commented May 1, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the bugfix/lr_finder branch from 96937b7 to 9d2ef91 Compare May 1, 2020 18:56
@awaelchli
Copy link
Contributor

@SkafteNicki it makes sense to use fit, that's very good :) we just have to keep it in mind when we add new trainer args :) 👍

@codecov
Copy link

codecov bot commented May 1, 2020 •
edited
Loading

Codecov Report

Merging #1676 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1676   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          69      69           
  Lines        4131    4135    +4     
======================================
+ Hits         3655    3659    +4     
  Misses        476     476

Borda
Borda reviewed May 1, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 1, 2020 20:31
@mergify mergify bot requested a review from a team May 1, 2020 20:32
@mergify
Copy link
Contributor

mergify bot commented May 2, 2020

This pull request is now in conflict... :(

@Borda Borda force-pushed the bugfix/lr_finder branch from fe910a5 to 9b8c3f9 Compare May 4, 2020 11:54
@williamFalcon williamFalcon merged commit e865b04 into Lightning-AI:master May 4, 2020
@SkafteNicki SkafteNicki deleted the bugfix/lr_finder branch May 25, 2020 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda approved these changes

@awaelchli awaelchli awaelchli approved these changes

@jeremyjordan jeremyjordan Awaiting requested review from jeremyjordan

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

KeyError: 'early_stop_callback_wait' when calling training with auto_lr_find no val_dataloader when lr_find
4 participants
@SkafteNicki @awaelchli @Borda @williamFalcon