generalize reinstantiation of dataloader #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusschock
requested review from
williamFalcon,
Borda,
ethanwharris and
jeremyjordan
|
This pull request is now in conflict... :( |
|
This pull request is now in conflict... :( |
|
@justusschock this is awesome. mind rebasing so we can get those GPU fixes from master? |
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
=======================================
+ Coverage 92% 92% +<1%
=======================================
Files 63 63
Lines 3316 3315 -1
=======================================
Hits 3040 3040
+ Misses 276 275 -1 |
Borda
force-pushed
the
dataloader_reinstantiation
branch
from
21ff726 to
79baaae
Compare
|
@williamFalcon resolved, @justusschock could you pls check it... |
|
LGTM, thanks @Borda |
|
@justusschock could you please approve it... @williamFalcon ^^ |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 4, 2020
* generalize reinstantiation of dataloader * fix condition * add test * update changelog * fix changelog Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Jun 7, 2020
* generalize reinstantiation of dataloader * fix condition * add test * update changelog * fix changelog Co-authored-by: J. Borovec <jirka.borovec@seznam.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Generalizes reinstantiation of data loaders to allow subclasses of data loader
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃