Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change default logger to dedicated one #1064

Merged
merged 1 commit into from
Mar 17, 2020
Merged

change default logger to dedicated one #1064

merged 1 commit into from
Mar 17, 2020

Conversation

cmpute
Copy link
Contributor

@cmpute cmpute commented Mar 6, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Changed the default logger to logging.getLogger("lightning") as proposed here: #710 (comment)
This modification won't make any difference to current users since the logging will propagate to root logger. However if the user want to distinguish the text log from pytorch-lightning from logs of other packages, they have an option now.

@Borda Borda added this to the 0.7.2 milestone Mar 7, 2020
@Borda
Copy link
Member

Borda commented Mar 11, 2020

hey there, we have added GPU CI test, so could we kindly ask to rebase/merge master which will trigger these tests so we do not need to test it manually... Thx for your understanding 🤖

@cmpute
Copy link
Contributor Author

cmpute commented Mar 12, 2020

Done!

@cmpute
Copy link
Contributor Author

cmpute commented Mar 14, 2020

Fixed

Borda
Borda requested changes Mar 15, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use absolute imports...
also not sure how it will interact if it is imported but basic level sett later, pls test...

pytorch_lightning/callbacks/early_stopping.py Outdated Show resolved Hide resolved
pytorch_lightning/core/__init__.py Outdated Show resolved Hide resolved
@cmpute
Copy link
Contributor Author

cmpute commented Mar 16, 2020

Rebased & fixed

@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #1064 into master will increase coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #1064    +/-   ##
=======================================
+ Coverage      89%     93%    +4%     
=======================================
  Files          62      61     -1     
  Lines        3163    2671   -492     
=======================================
- Hits         2809    2471   -338     
+ Misses        354     200   -154

@cmpute cmpute requested a review from Borda March 16, 2020 22:55
Borda
Borda approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just a minor comment with imports and add note to CHANGELOG
also, could you check bit complains about doc even it is not related to your PR

pytorch_lightning/__init__.py Outdated Show resolved Hide resolved
pytorch_lightning/profiler/profiler.py Outdated Show resolved Hide resolved
@Borda Borda added the feature Is an improvement or enhancement label Mar 16, 2020
@cmpute
Copy link
Contributor Author

cmpute commented Mar 17, 2020

About the docs, I didn't read into them carefully so I think I can make improvements after I'm more familiar with the framework

@Borda
Copy link
Member

Borda commented Mar 17, 2020

@cmpute could you pls update from master? we have fixed the failure in #1163

@cmpute
change default logger to dedicated one
32caeff 
Fix test


Fix format

Update pytorch_lightning/__init__.py
Separate imports
@cmpute
Copy link
Contributor Author

cmpute commented Mar 17, 2020

Rebased

@Borda Borda added the ready PRs ready to be merged label Mar 17, 2020
@williamFalcon williamFalcon self-requested a review March 17, 2020 22:43
@williamFalcon williamFalcon merged commit 1a73fa0 into Lightning-AI:master Mar 17, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Apr 3, 2020
@cmpute @tullie
change default logger to dedicated one (Lightning-AI#1064)
c35a6bf 
Fix test


Fix format

Update pytorch_lightning/__init__.py
Separate imports
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli left review comments

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.
4 participants
@cmpute @Borda @awaelchli @williamFalcon