Don't change CWD on startup #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #39 changing the current working directory is an unexpected side effect that largely stems from legacy PySCeS code at a time when the
HOMEenvironment variable was not properly defined under Windows.This PR introduces a new configuration option
change_dir_on_start = Falseinpyscfg.inias well as.pys_usercfg.ini. The default installation option isFalsebut can be set toTruein user configuration. WhenFalse, the current working directory is maintained upon importing pysces and loading a model. When set toTrue, the previous behaviour results, i.e. change directory to$HOME/Pyscesafter importing pysces and loading a model.Note that the option to set the model directory and output directory to the current working directory still exists in
.pys_usercfg.ini, as it has for some time already. This is for keeping PSC files in a folder related to a particular project and not in a central folder, by setting the options as follows: