Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc_flags #38

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Add rustc_flags #38

merged 2 commits into from
Aug 8, 2018

Conversation

pganssle
Copy link
Member

@pganssle pganssle commented Aug 8, 2018

Currently it's not possible to pass --cfg flags other than features to the build. This adds a new option to RustExtension that allows you to pass arguments to rustc instead of cargo.

I'd be fine with changing the name of this argument or refactoring it.

I didn't see any tests for this module, so I didn't add tests for this situation.

@konstin
Copy link
Member

konstin commented Aug 8, 2018

Thanks!

@konstin konstin merged commit f15e8fb into PyO3:master Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants