Allow connecting to the DB from a specific network interface #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(hostname or IP address)
|
just a note we are imitating MySQL's own API here, which should also be supported in mysqlclient: MYSQL_OPT_BIND at http://dev.mysql.com/doc/refman/5.7/en/mysql-options.html |
methane
requested changes
Nov 16, 2016
| @@ -534,7 +534,8 @@ def __init__(self, host=None, user=None, password="", | |||
| compress=None, named_pipe=None, no_delay=None, | |||
| autocommit=False, db=None, passwd=None, local_infile=False, | |||
| max_allowed_packet=16*1024*1024, defer_connect=False, | |||
| auth_plugin_map={}, read_timeout=None, write_timeout=None): | |||
| auth_plugin_map={}, read_timeout=None, write_timeout=None, | |||
| bind=None): | |||
There was a problem hiding this comment.
I prefer bind_address rather than bind. (Same to option name, translated '-' with '_')
| @@ -640,6 +645,9 @@ def _config(key, arg): | |||
| self.password = password or "" | |||
| self.db = database | |||
| self.unix_socket = unix_socket | |||
| if bind is not None and _py_version == (2, 6): | |||
| raise NotImplementedError("bind before connect is not supported in Python 2.6") | |||
There was a problem hiding this comment.
Python 2.6 is not supported anymore. So this check is not required.
methane
approved these changes
Nov 16, 2016
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting via TCP/IP, provide a means to the client to bind the
socket to be created to a specific source address. This is useful
when the client host has multiple network interfaces and a specific
one must be used for database traffic.
Add a new optional "bind" argument to class Connection, to specify the
interface from which to connect to the DB. Argument can be a hostname
or an IP address.