Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields from GithubCredentials.py to CONTRIBUTING.md #2482

Merged
merged 1 commit into from
May 9, 2023

Conversation

JLLeitschuh
Copy link
Collaborator

No description provided.

@JLLeitschuh JLLeitschuh changed the title Add fields missing from GithubCredentials.py ion CONTRIBUTING.md Add fields missing from GithubCredentials.py from CONTRIBUTING.md Mar 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (bab4180) 98.77% compared to head (262444f) 98.77%.

❗ Current head 262444f differs from pull request most recent head 8ea7484. Consider uploading reports for the commit 8ea7484 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         117      117              
  Lines       11702    11689      -13     
==========================================
- Hits        11559    11546      -13     
  Misses        143      143              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EnricoMi EnricoMi changed the title Add fields missing from GithubCredentials.py from CONTRIBUTING.md Add missing fields from GithubCredentials.py to CONTRIBUTING.md May 8, 2023
Copy link
Collaborator

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi
Copy link
Collaborator

EnricoMi commented May 9, 2023

@JLLeitschuh feel free to "Squash and merge" into master.

@JLLeitschuh JLLeitschuh merged commit 297317b into PyGithub:master May 9, 2023
@JLLeitschuh JLLeitschuh deleted the patch-2 branch May 9, 2023 22:33
@JLLeitschuh
Copy link
Collaborator Author

Can we make that the default via the repository settings?

@EnricoMi
Copy link
Collaborator

See the Slack discussion...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants