Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tox #1388

Merged
merged 19 commits into from
Feb 13, 2020
Merged

Add tox #1388

merged 19 commits into from
Feb 13, 2020

Conversation

sfdye
Copy link
Member

@sfdye sfdye commented Feb 10, 2020 •
edited
Loading

  • Migrate all virtualenvs to tox
  • Support for python3.5 - Python 3.8
  • Add travis check for flake8/black/isort
  • Add a tox command format for manual formatting

@TravisBuddy
Copy link

Travis tests have failed

Hey @sfdye,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

tox 
Collecting tox
  Downloading https://files.pythonhosted.org/packages/77/a7/a5b721d9bf955edfe36013e5ecc9136fc6b2fef622ab1797ff0560273d8e/tox-3.14.3-py2.py3-none-any.whl (80kB)

Collecting toml>=0.9.4 (from tox)
  Downloading https://files.pythonhosted.org/packages/a2/12/ced7105d2de62fa7c8fb5fce92cc4ce66b57c95fb875e9318dba7f8c5db0/toml-0.10.0-py2.py3-none-any.whl
Requirement already satisfied: py<2,>=1.4.17 in /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages (from tox) (1.7.0)
Collecting importlib-metadata<2,>=0.12; python_version < "3.8" (from tox)
  Downloading https://files.pythonhosted.org/packages/8b/03/a00d504808808912751e64ccf414be53c29cad620e3de2421135fcae3025/importlib_metadata-1.5.0-py2.py3-none-any.whl
Requirement already satisfied: six<2,>=1.0.0 in /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages (from tox) (1.11.0)
Requirement already satisfied: virtualenv>=16.0.0 in /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages (from tox) (16.0.0)
Collecting pluggy<1,>=0.12.0 (from tox)
  Downloading https://files.pythonhosted.org/packages/a0/28/85c7aa31b80d150b772fbe4a229487bc6644da9ccb7e427dd8cc60cb8a62/pluggy-0.13.1-py2.py3-none-any.whl
Collecting filelock<4,>=3.0.0 (from tox)
  Downloading https://files.pythonhosted.org/packages/93/83/71a2ee6158bb9f39a90c0dea1637f81d5eef866e188e1971a1b1ab01a35a/filelock-3.0.12-py3-none-any.whl
Collecting packaging>=14 (from tox)
  Downloading https://files.pythonhosted.org/packages/98/42/87c585dd3b113c775e65fd6b8d9d0a43abe1819c471d7af702d4e01e9b20/packaging-20.1-py2.py3-none-any.whl
Collecting zipp>=0.5 (from importlib-metadata<2,>=0.12; python_version < "3.8"->tox)
  Downloading https://files.pythonhosted.org/packages/46/42/f2dd964b2a6b1921b08d661138148c1bcd3f038462a44019416f2342b618/zipp-2.2.0-py36-none-any.whl
Collecting pyparsing>=2.0.2 (from packaging>=14->tox)
  Downloading https://files.pythonhosted.org/packages/5d/bc/1e58593167fade7b544bfe9502a26dc860940a79ab306e651e7f13be68c2/pyparsing-2.4.6-py2.py3-none-any.whl (67kB)

Installing collected packages: toml, zipp, importlib-metadata, pluggy, filelock, pyparsing, packaging, tox
  Found existing installation: pluggy 0.8.0
    Uninstalling pluggy-0.8.0:
      Successfully uninstalled pluggy-0.8.0
Successfully installed filelock-3.0.12 importlib-metadata-1.5.0 packaging-20.1 pluggy-0.13.1 pyparsing-2.4.6 toml-0.10.0 tox-3.14.3 zipp-2.2.0
$ tox
GLOB sdist-make: /home/travis/build/PyGithub/PyGithub/setup.py
py37 create: /home/travis/build/PyGithub/PyGithub/.tox/py37
ERROR: InterpreterNotFound: python3.7
___________________________________ summary ____________________________________
ERROR:  py37: InterpreterNotFound: python3.7
TravisBuddy Request Identifier: ecce1f50-4c1f-11ea-a602-3b1447b731d3

@PyGithub PyGithub deleted a comment from TravisBuddy Feb 10, 2020
@PyGithub PyGithub deleted a comment from TravisBuddy Feb 10, 2020
@PyGithub PyGithub deleted a comment from TravisBuddy Feb 10, 2020
s-t-e-v-e-n-k
s-t-e-v-e-n-k requested changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broadly, I love it. I have some concerns I've detailed inline.

tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@7f6a303). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1388   +/-   ##
=========================================
  Coverage          ?   98.33%           
=========================================
  Files             ?      188           
  Lines             ?    14084           
  Branches          ?        0           
=========================================
  Hits              ?    13850           
  Misses            ?      234           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6a303...847ac91. Read the comment docs.

sfdye
sfdye commented Feb 11, 2020
View reviewed changes
.flake8
@@ -1,4 +0,0 @@
[flake8]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is moved to tox.ini

@sfdye sfdye marked this pull request as ready for review February 11, 2020 18:15
@sfdye sfdye requested a review from s-t-e-v-e-n-k February 11, 2020 18:16
@sfdye
Copy link
Member Author

sfdye commented Feb 11, 2020

@s-t-e-v-e-n-k Now it's ready for review :)

s-t-e-v-e-n-k
s-t-e-v-e-n-k approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it, I want it. I have two small niggles, but not fussed if they get fixed before or after merging.

test-requirements.txt Outdated Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@sfdye
Copy link
Member Author

sfdye commented Feb 13, 2020

image

Now travis will fail either flake8/isort/black fails the check.

@sfdye sfdye merged commit 125536f into master Feb 13, 2020
@sfdye sfdye deleted the add-tox branch February 13, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfdye @TravisBuddy @codecov-io @s-t-e-v-e-n-k