Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read TaskPriorityClass from config #872

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Read TaskPriorityClass from config #872

merged 2 commits into from
Sep 6, 2023

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 6, 2023 •
edited
Loading

Description

Change to read task priority class for Argo jobs to empty string by default since the value standard is non-generic and not available by default.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp
Read TaskPriorityClass from config
556f373 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@mocsharp mocsharp added the enhancement New feature or request label Sep 6, 2023
@mocsharp mocsharp added this to the 0.1.28 milestone Sep 6, 2023
@mocsharp mocsharp self-assigned this Sep 6, 2023
@mocsharp
Fix unit test
a251027 
Signed-off-by: Victor Chang <vicchang@nvidia.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@mocsharp mocsharp merged commit 195cccd into develop Sep 6, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 0.1.29 🎉

The release is available on:

@mocsharp mocsharp deleted the vchang/task-priority branch June 11, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neildsouth neildsouth neildsouth approved these changes

@woodheadio woodheadio Awaiting requested review from woodheadio

Assignees

@mocsharp mocsharp

Labels
enhancement New feature or request
Projects
Clinical Data Pipelines
Status: Done
Milestone
0.1.29
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @neildsouth