This repository has been archived by the owner on Apr 10, 2023. It is now read-only.
Add Rest endpoint to check if email exists #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knjk04
suggested changes
Feb 16, 2022
|
Hi @knjk04, for some reasons MockMvc is not working, it is blocking me from writing test, could you help regarding the same? |
|
Hi @kuruvasatya, sure. I can help you with this. How come you closed this pull request? |
|
Hey @knjk04, that was by mistake, i am able to test the service, but for testing controller I think we need MockMvc, that seems to be not working, please help me |
|
Hey @knjk04 any Updates, its been days |
mslowiak
suggested changes
Mar 2, 2022
| @@ -88,6 +90,16 @@ public User getUser(@PathVariable Long id) { | |||
| ); | |||
| } | |||
|
|
|||
| @GetMapping("/email/{email}") | |||
| public ResponseEntity<String> checkIfEmailExists(@PathVariable String email) { | |||
| Optional<User> user = userService.findUserByEmail(email); | |||
There was a problem hiding this comment.
userService.findUserByEmail(email)
.map(user-> ResponseEntity.ok())
.orElse(ResponseEntity.status(HttpStatus.NOT_FOUND).body(EMAIL_NOT_FOUND));
There was a problem hiding this comment.
@mslowiak I don't think that'll work:
|
Hi @kuruvasatya, so sorry for the delay & thanks for chasing up. I didn't get a chance to implement this, but I'll do it now. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Added new rest endpoint in the UserController.java class to check if email exists or not
Related issue
Closes #925
Pull request checklist
Please keep this checklist in & ensure you have done the following:
Read, understood and adhered to our contributing document.
Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
Set this pull request to 'draft' if you are still working on it
Resolved any merge conflicts
Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.