Simplify Procedure ConditionEvaluator state management #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a rare race condition in which Conditions could begin to be evaluated prior to all of the parent Procedure’s dependencies finishing.
|
@swiftlyfalling - will look at this tomorrow. 👍 |
danthorpe
approved these changes
Jul 28, 2017
Merged
danthorpe
added a commit
that referenced
this pull request
Aug 3, 2017
e28d4e4 Adds Result Injection documentation (#779) 90b0034 Simplify Procedure ConditionEvaluator state management (#777) 0d6f17f Additional doc tweaks (#775) 5621af3 Fixes unstable tests (#774) 4cccf27 Fixes unstable test: `test__profile_operation__which_produces_child` (#770) e25d205 Documentation guides formatting tweaks (#773) e65a09a Fix race condition in TestProcedure (#769) c12267f Move Guides to the Documentation folder (#772) ab9a269 Customize jazzy (documentation) theme (#771) 86e074b Documentation tweaks and improvements (#768) d482c07 Adds documentation for Groups (#767) e56965e Adds Cancellation guides (#766) 6a15f80 Complies to GitHub's code of conduct template. 71c141c Renames code of conduct file 1162db9 Fixes mistake in README 6e68517 Creates documentation guides from wiki content, part 1 (#751) e2ca662 Updates links to reference docs (#763) c468d73 Improves CocoaPods instructions (#762) d6389ea Resolve ProcedureObserver errors on Xcode 9 beta 3 (#754) (#752) 52f5de8 Fixes (very) rare race conditions involving Conditions (#756) 1442dae Improve QualityOfServiceTests (#757) 79708b7 [development]: Updates README with doc % badge da2be45 Adds trigger to build ProcedureKit documentation (#750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a rare race condition in which Conditions could begin to be evaluated prior to all of the parent Procedure’s dependencies finishing.