-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PHP constants for doctrine config #36840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
@PrestaShop/qa-functional no functional tests are needed in my opinion, installation process is tested multiple times in automated tests |
Ok @kpodemski , I agree :) |
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |
thank you @matks ! |
PDO::MYSQL_ATTR_MULTI_STATEMENTS
change on different environments . This PR is targeting8.2.x
instead ofdevelop
and replaces #36732How to test
As this is a config specific item, the behavior of the shop should be unchanged. To verify the item, a developer could do:
develop
branch and insert the below 2 lines in a Symfony controller to be able to verify the value of the configuration options passed to Doctrine2 lines of code
The behavior is "nothing has changed" because I believe the fix will only fix the situation for a subset of users, victims of #33524