Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve access controls #36203

Merged
merged 3 commits into from
May 22, 2024
Merged

Improve access controls #36203

merged 3 commits into from
May 22, 2024

Conversation

jolelievre
Copy link
Contributor

@jolelievre jolelievre commented May 20, 2024 •
edited
Loading

Questions Answers
Branch? develop
Description? Adapt access controls and LegacyController to allow anonymous legacy controllers without being authenticated
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? CI green UI tests green, For cron URL go to BO in Shop parameters > Search Copy the search clean cron URL and open it in a private tab (no logged in user), the URL should succeed (a white page is displayed, no redirection to the login page)
UI Tests https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/9165903589
Fixed issue or discussion? Fixes #36180 and Fixes #36204
Related PRs ~
Sponsor company ~

@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels May 20, 2024
@jolelievre jolelievre marked this pull request as ready for review May 20, 2024 17:27
@jolelievre jolelievre requested a review from a team as a code owner May 20, 2024 17:27
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label May 21, 2024
@jolelievre jolelievre merged commit 5155267 into PrestaShop:develop May 22, 2024
38 checks passed
@jolelievre jolelievre deleted the improve-access-controls branch May 22, 2024 13:07
@jolelievre jolelievre added this to the 9.0.0 milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@boherm boherm boherm approved these changes

@tleon tleon tleon approved these changes

Assignees
No one assigned
Labels
develop Branch Improvement Type: Improvement Waiting for QA Status: action required, waiting for test feedback
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
6 participants
@jolelievre @tleon @boherm @M0rgan01 @ps-jarvis @prestonBot