Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View templatesRemove email "Preview" from BO section "Statutes" (because it's not working) #36171

Merged
merged 3 commits into from
Jun 25, 2024
Merged

View templatesRemove email "Preview" from BO section "Statutes" (because it's not working) #36171

merged 3 commits into from
Jun 25, 2024

Conversation

ShaiMagal
Copy link
Contributor

@ShaiMagal ShaiMagal commented May 15, 2024 •
edited by florine2623
Loading

Questions Answers
Branch? 8.1.x
Description? Check issue #36165
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Go to any Order State with mail template and check, if there is button "Preview"
UI Tests https://github.com/florine2623/testing_pr/actions/runs/9658853714 ✅
Fixed issue or discussion? Fixes #36165
Related PRs
Sponsor company https://www.openservis.cz/

@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels May 15, 2024
@ShaiMagal ShaiMagal marked this pull request as ready for review May 15, 2024 19:30
@ShaiMagal ShaiMagal requested a review from a team as a code owner May 15, 2024 19:30
@ShaiMagal ShaiMagal mentioned this pull request May 15, 2024
Closed
2 tasks
kpodemski
kpodemski requested changes May 15, 2024
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not how we should do things, removing something because it stopped working is not a solution.

@kpodemski
Copy link
Contributor

Isn't a solution to simply allow browsing these files in the .htaccess?

@Hlavtox
Copy link
Contributor

Hlavtox commented May 15, 2024

@kpodemski probably a security issue, everyone could browse your templates

@ShaiMagal
Copy link
Contributor Author

ShaiMagal commented May 15, 2024 •
edited
Loading

@kpodemski But this is not working for 4 years (#17759)... It's nothing new...

So better option is to leave this still not working and still explaining customers? seriously? :-D

Better option for me is hide this, if this is not working for 4 years already. Customers are complaining. Hiding is not ideal solution, but better than leave this feature still broken....... :/

Unfortunatelly, no :( because, it will allow "attacker" to see content of this mail templates. And this is purpose of .htaccess to hide this from public.

kpodemski
kpodemski approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. From the code perspective, it's good, from the product point of view, I'd like to see @MatShir opinion on this one, I think it's not the end of the world to temporarily disable this.

@kpodemski kpodemski added the Waiting for PM Status: action required, waiting for product feedback label May 16, 2024
@MatShir
Copy link
Contributor

MatShir commented May 23, 2024

LGTM 👌
thanks @ShaiMagal !

@kpodemski kpodemski added PM ✔️ Status: check done, behavior approved and removed Waiting for PM Status: action required, waiting for product feedback labels May 24, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jun 19, 2024
@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jun 25, 2024
@ps-jarvis
Copy link

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

florine2623
florine2623 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is QA ✅

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Jun 25, 2024
@florine2623 florine2623 removed the Waiting for QA Status: action required, waiting for test feedback label Jun 25, 2024
@Hlavtox Hlavtox added this to the 8.1.8 milestone Jun 25, 2024
@Hlavtox Hlavtox merged commit b5c29fd into PrestaShop:8.1.x Jun 25, 2024
38 checks passed
@ShaiMagal ShaiMagal deleted the viewTemplates branch August 3, 2024 15:44
@kpodemski kpodemski added Bug fix Type: Bug fix and removed Improvement Type: Improvement labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florine2623 florine2623 florine2623 approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

@kpodemski kpodemski kpodemski approved these changes

@nicosomb nicosomb Awaiting requested review from nicosomb

@M0rgan01 M0rgan01 Awaiting requested review from M0rgan01

Assignees
No one assigned
Labels
8.1.x Branch Bug fix Type: Bug fix PM ✔️ Status: check done, behavior approved QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ShaiMagal @kpodemski @Hlavtox @MatShir @ps-jarvis @florine2623 @prestonBot