Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTMLTemplateOrderSlip.php to fix #35802 #35861

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Update HTMLTemplateOrderSlip.php to fix #35802 #35861

merged 1 commit into from
Apr 10, 2024

Conversation

rudolfkastl
Copy link
Contributor

@rudolfkastl rudolfkastl commented Apr 8, 2024 •
edited by florine2623
Loading

Fixes: #35802

Questions Answers
Branch? 8.1.x
Description? Fixes issue #35802. This is a regression as this had been fixed before.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
How to test? Without this fix, no correction invoices can be downloaded from the shop
UI Tests https://github.com/florine2623/testing_pr/actions/runs/8632250955 ✅
Fixed issue or discussion? Fixes #35802
Related PRs none
Sponsor company none

@rudolfkastl rudolfkastl requested a review from a team as a code owner April 8, 2024 11:48
@prestonBot
Copy link
Collaborator

Hello @rudolfkastl!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@prestonBot
Copy link
Collaborator

Hi, thanks for this contribution!

I found some issues with the Pull Request description:

  • The category should be one of these: BO, CO, FO, IN, LO, ME, PM, TE or WS (Read explanation)

Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!

(Note: this is an automated message, but answering it will reach a real human)

@prestonBot prestonBot added Bug fix Type: Bug fix BC break Type: Introduces a backwards-incompatible break labels Apr 8, 2024
@boherm
Copy link
Member

boherm commented Apr 9, 2024

Thanks for your first contribution @rudolfkastl ;)

@boherm boherm removed the BC break Type: Introduces a backwards-incompatible break label Apr 9, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Apr 10, 2024
@prestonBot prestonBot added the 8.1.x Branch label Apr 10, 2024
@kpodemski
Copy link
Contributor

kpodemski commented Apr 10, 2024 •
edited
Loading

@PrestaShop/qa-functional

You already tested similar PR recently, this is just a straightforward backport. Can we merge?

#35439

@florine2623 florine2623 self-assigned this Apr 10, 2024
florine2623
florine2623 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rudolfkastl @kpodemski ,

The auto tests are green.
It has been tested, the credit slip doesn't display an error and is viewable correctly.

It is QA ✅

Thanks !

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Apr 10, 2024
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@nicosomb nicosomb merged commit ecbbfb2 into PrestaShop:8.1.x Apr 10, 2024
38 checks passed
@kpodemski kpodemski added this to the 8.1.6 milestone Apr 10, 2024
@kpodemski
Copy link
Contributor

thank you @rudolfkastl

@matthieu-rolland matthieu-rolland modified the milestones: 8.1.6, 8.1.7 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boherm boherm boherm approved these changes

@florine2623 florine2623 florine2623 approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@rudolfkastl @prestonBot @boherm @kpodemski @florine2623 @nicosomb @matthieu-rolland @ps-jarvis