Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve wording of pack quantities #35434

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Improve wording of pack quantities #35434

merged 4 commits into from
Apr 9, 2024

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Feb 21, 2024 •
edited
Loading

Questions Answers
Branch? 8.1.x
Description? Improves the wording of pack behavior management. Sometimes even we struggle to see what the options mean.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test?
UI Tests https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8186337386
Fixed issue or discussion?
Related PRs
Sponsor company

@Hlavtox Hlavtox added this to the 8.1.5 milestone Feb 21, 2024
@Hlavtox Hlavtox requested a review from a team as a code owner February 21, 2024 09:02
@prestonBot prestonBot added 8.1.x Branch Improvement Type: Improvement labels Feb 21, 2024
@Hlavtox Hlavtox changed the base branch from develop to 8.1.x February 21, 2024 09:02
@Hlavtox Hlavtox force-pushed the pack-quantity-wording branch from e000717 to 8fcdfe3 Compare February 21, 2024 09:04
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 21, 2024

Ping @kpodemski @MatShir @Julievrz

boherm
boherm previously approved these changes Feb 21, 2024
View reviewed changes
@MatShir MatShir added Waiting for PM Status: action required, waiting for product feedback Waiting for wording Status: action required, waiting for wording labels Feb 21, 2024
FabienPapet
FabienPapet previously approved these changes Feb 21, 2024
View reviewed changes
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Feb 21, 2024
@Julievrz
Copy link
Contributor

Hi @Hlavtox
What do you think of taking inspiration from the "When out of stock" section just below on the page?

Here's an example:

Screenshot 2024-02-23 at 10 33 28

Also, what do you think of adding the "Edit default behavior" link in this section too?

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Feb 23, 2024 •
edited
Loading

@Julievrz Yes, we could add the link. But I wanted to specifically name it "stock behavior" or "how to calculate stock", because right now it just says how the quantity will be decreased, but it ALSO/MAINLY means HOW the stock is calculated in the first place.

This configuration value means both:

  • How the quantity is calculated.
  • What will be decreased after order.

Full explanation here: #35367 (comment)

@Julievrz
Copy link
Contributor

@Julievrz Yes, we could add the link. But I wanted to specifically name it "stock behavior" or "how to calculate stock", because right now it just says how the quantity will be decreased, but it ALSO/MAINLY means HOW the stock is calculated in the first place.

This configuration value means both:

  • How the quantity is calculated.
  • What will be decreased after order.

Full explanation here: #35367 (comment)

Thanks, it's way clearer with the full explanation. :)

@Julievrz Julievrz added the Waiting for author Status: action required, waiting for author feedback label Feb 26, 2024
@Hlavtox Hlavtox modified the milestones: 8.1.5, 8.1.6 Feb 27, 2024
@Hlavtox Hlavtox dismissed stale reviews from FabienPapet and boherm via df5a507 March 5, 2024 09:57
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Mar 5, 2024

@Julievrz Wording applied. I also added the link to edit default settings, that's a good idea. :-)

Snímek obrazovky 2024-03-05 105758

@Hlavtox Hlavtox removed Waiting for author Status: action required, waiting for author feedback Waiting for QA Status: action required, waiting for test feedback Waiting for wording Status: action required, waiting for wording Waiting for PM Status: action required, waiting for product feedback labels Mar 5, 2024
@Hlavtox Hlavtox requested review from FabienPapet and boherm March 5, 2024 09:59
@Hlavtox Hlavtox requested review from kpodemski and MatShir March 5, 2024 09:59
@Julievrz Julievrz added the Wording ✔️ Status: check done, wording approved label Mar 5, 2024
MatShir
MatShir previously approved these changes Mar 5, 2024
View reviewed changes
@MatShir MatShir added the PM ✔️ Status: check done, behavior approved label Mar 5, 2024
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Mar 5, 2024

Auto test - https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8154574648

kpodemski
kpodemski previously requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kpodemski kpodemski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that e2e tests have to be adapted to the new wording.

@ps-jarvis ps-jarvis added the Waiting for author Status: action required, waiting for author feedback label Mar 7, 2024
@Hlavtox Hlavtox requested a review from a team as a code owner March 7, 2024 10:05
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Mar 7, 2024

New run https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/8186337386

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Mar 7, 2024

@kpodemski All green, can we merge?

@Hlavtox Hlavtox removed the Waiting for author Status: action required, waiting for author feedback label Mar 7, 2024
@Hlavtox Hlavtox requested a review from kpodemski March 15, 2024 15:26
@Hlavtox Hlavtox requested a review from a team April 2, 2024 09:17
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Apr 2, 2024

Ping @kpodemski @boherm for re-review 🙏

@marsaldev marsaldev merged commit dca7bbe into PrestaShop:8.1.x Apr 9, 2024
41 of 44 checks passed
@matks matks modified the milestones: 8.1.6, 8.1.7 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julievrz Julievrz Julievrz left review comments

@nesrineabdmouleh nesrineabdmouleh nesrineabdmouleh approved these changes

@boherm boherm boherm approved these changes

@MatShir MatShir MatShir left review comments

@FabienPapet FabienPapet Awaiting requested review from FabienPapet

@kpodemski kpodemski Awaiting requested review from kpodemski

Assignees
No one assigned
Labels
8.1.x Branch Improvement Type: Improvement PM ✔️ Status: check done, behavior approved Wording ✔️ Status: check done, wording approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.7
Development

Successfully merging this pull request may close these issues.