Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Catalog - Stocks - multiple filters not working #35384

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fix: Catalog - Stocks - multiple filters not working #35384

merged 3 commits into from
Mar 6, 2024

Conversation

Codencode
Copy link
Contributor

@Codencode Codencode commented Feb 16, 2024 •
edited by florine2623
Loading

Questions Answers
Branch? 8.1.x
Description? In search in Catalog - Stocks when I add multiple filters, no products are shown. If I use only one keyword in search it is working.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
 UI Tests https://github.com/florine2623/testing_pr/actions/runs/8173612011 ✅
How to test? Go to Catalog > Stock and perform a 2-word search
Fixed issue or discussion? Fixes #35280
Sponsor company Codencode

@Codencode Codencode requested a review from a team as a code owner February 16, 2024 09:08
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Feb 16, 2024
@Codencode Codencode changed the title Catalog - Stocks - multiple filters not working Fix: Catalog - Stocks - multiple filters not working Feb 16, 2024
@kpodemski
Copy link
Contributor

Hello @Codencode

Tests related to this piece of code are red. There is a test scenario that shows some troubles.

@Codencode
Copy link
Contributor Author

Hello @Codencode

Tests related to this piece of code are red. There is a test scenario that shows some troubles.

Hi @kpodemski,
in fact the change did not take into account other scenarios.
I made a change, let's see if it works.

Thank you.

@PrestaShop PrestaShop deleted a comment from prestonBot Feb 25, 2024
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Mar 4, 2024
@florine2623 florine2623 self-assigned this Mar 6, 2024
florine2623
florine2623 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Codencode ,

Tested the basic case, tested with all the keywords in the title of the product, tested within a product title

Tested another case, where I have :

  • 1 product titled "bird"
  • A few products titled "hummingbird"

If I search for "bird", all the products mentioned above are displayed ✅
If I search for "bird" + "humming", only my products "hummingbird" will be displayed ✅
If I search for "hummingbird", only my products "hummingbird" will be displayed ✅

It is QA ✅
Thanks!

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 6, 2024
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@kpodemski kpodemski added this to the 8.1.5 milestone Mar 6, 2024
@FabienPapet
Copy link
Member

Thank you @Codencode

@FabienPapet FabienPapet merged commit 3527391 into PrestaShop:8.1.x Mar 6, 2024
38 checks passed
@florine2623 florine2623 mentioned this pull request Mar 11, 2024
Merged
@Codencode Codencode mentioned this pull request Mar 29, 2024
Closed
2 tasks
@Codencode Codencode deleted the fix-35280 branch September 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@florine2623 florine2623 florine2623 approved these changes

@TheoAlloin TheoAlloin TheoAlloin approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.5
Development

Successfully merging this pull request may close these issues.
8 participants
@Codencode @kpodemski @prestonBot @FabienPapet @TheoAlloin @florine2623 @M0rgan01 @ps-jarvis