Enable attribute migrated page #35270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Feb 5, 2024
•
jolelievre
commented
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | Enable attribute migrated page, remove feature flag, clean legacy code |
| Type? | new feature |
| Category? | BO |
| BC breaks? | yes |
| Deprecations? | no |
| How to test? | UI tests and CI green, test the new attribute and attribute group page (lists, creation forms, edition forms) |
| UI Tests | https://github.com/jolelievre/ga.tests.ui.pr/actions/runs/8618370446 |
| Fixed issue or discussion? | Fixes #10508 |
| Related PRs | ~ |
| Sponsor company | ~ |
prestonBot
added
Feature
M0rgan01
previously approved these changes
Feb 6, 2024
Hlavtox
previously approved these changes
Feb 6, 2024
There was a problem hiding this comment.
🚀
@PrestaShop/qa-functional Please, do a throughout check and verify:
- That the forms redirect to proper place after saving values. If you save a value, it redirects you to the value list of the attribute, not the attribute list. Both when creating a new one and editing an existing value.
- That the rows are clickable like in old versions. Click attribute -> opens value list. Click value -> open edit form.
@jolelievre I see one bug ;-)
Hlavtox
added
the
Waiting for QA
boherm
previously approved these changes
Feb 7, 2024
|
Hello @jolelievre, The auto test returns an error, can you look at this as well as the bug reported by Hlavtox? Thanks! |
paulnoelcholot
added
Waiting for author
|
Blocked by PR on module faceted search PrestaShop/ps_facetedsearch#979 |
|
Blocked by PrestaShop/ps_facetedsearch#983 and PrestaShop/ps_facetedsearch#981 |
jolelievre
force-pushed
the
enable-attribute-migrated-page
branch
from
75f0afc to
936174d
Compare
jolelievre
removed
the
Waiting for author
Progi1984
force-pushed
the
enable-attribute-migrated-page
branch
from
936174d to
1a05b01
Compare
jolelievre
force-pushed
the
enable-attribute-migrated-page
branch
4 times, most recently
from
e78aacf to
1d1192d
Compare
jolelievre
force-pushed
the
enable-attribute-migrated-page
branch
from
1d1192d to
c636561
Compare
nicosomb
force-pushed
the
enable-attribute-migrated-page
branch
from
ea298c2 to
6b28c32
Compare
nicosomb
approved these changes
Apr 16, 2024
matthieu-rolland
approved these changes
Apr 17, 2024
boherm
approved these changes
Apr 17, 2024
nesrineabdmouleh
approved these changes
Apr 17, 2024
WahbiPS
removed
the
Waiting for author
|
Latest auto tests ✅ https://github.com/florine2623/testing_pr/actions/runs/8718616685 |
|
FYI @paulnoelcholot 😄 |
|
@florine2623 From my quick check now, half of the issues are still there... Bug 2 - not fixed |
|
We planned to open new PR for the other bugs. |
|
If you find some more don't hesitate to enrich this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.