Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve front office date validation #34462

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Improve front office date validation #34462

merged 1 commit into from
Nov 6, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented Nov 3, 2023 •
edited
Loading

Questions Answers
Branch? 8.1.x
Description? Better validates dates in front office to account for NULL or zero dates.
Type? bug fix
Category? FO
BC breaks? no
Deprecations? no
How to test? Tests green & see below
UI Tests https://github.com/Hlavtox/ga.tests.ui.pr/actions/runs/6746117604
Fixed issue or discussion? Fixes #34441 (comment)
Related PRs
Sponsor company

How to test

  • Duplicate a product in backoffice using new product page.
  • Go to front office and there should be notices when visiting this product.

cc @florine2623

@Hlavtox Hlavtox requested a review from a team as a code owner November 3, 2023 13:57
@prestonBot prestonBot added 8.1.x Branch Bug fix Type: Bug fix labels Nov 3, 2023
@PrestaShop PrestaShop deleted a comment from prestonBot Nov 3, 2023
@florine2623 florine2623 self-assigned this Nov 3, 2023
@M0rgan01 M0rgan01 added this to the 8.1.3 milestone Nov 3, 2023
@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Nov 3, 2023
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Nov 5, 2023

@florine2623 Tests green ;-)

florine2623
florine2623 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA ✅ no more deprecated alert on FO !
Thanks @Hlavtox

@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Nov 6, 2023
@Hlavtox Hlavtox merged commit 54cea5b into PrestaShop:8.1.x Nov 6, 2023
38 checks passed
@Hlavtox Hlavtox deleted the isdateimprovement branch November 10, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@florine2623 florine2623 florine2623 approved these changes

@matks matks matks approved these changes

@matthieu-rolland matthieu-rolland Awaiting requested review from matthieu-rolland

@tleon tleon Awaiting requested review from tleon

@boherm boherm Awaiting requested review from boherm

@kpodemski kpodemski Awaiting requested review from kpodemski

Assignees

@florine2623 florine2623

Labels
8.1.x Branch Bug fix Type: Bug fix QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
8.1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@Hlavtox @matks @florine2623 @M0rgan01 @ps-jarvis @prestonBot