Handle via javascript that the two fields for impact are synced, mean… #34023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jolelievre
commented
Sep 21, 2023
jolelievre
commented
| Questions | Answers |
|---|---|
| Branch? | 8.1.x |
| Description? | Handle via javascript that the two fields for impact are synced, meaning they are both enabled/disabled at the same time |
| Type? | bug fix |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Try to modify the impact on price on a combination via bulk action, the two inputs for price tax excluded/included should be synced so no more error when only price tax included is provided |
| UI Tests | ~ |
| Fixed issue or discussion? | Fixes #33580 |
| Related PRs | ~ |
| Sponsor company | ~ |
|
Hi, thanks for this contribution! I found some issues with the Pull Request description:
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much! About linked issuesPlease consider opening an issue before submitting a Pull Request:
(Note: this is an automated message, but answering it will reach a real human) |
2 tasks
matks
previously approved these changes
Sep 25, 2023
M0rgan01
reviewed
Sep 26, 2023
| import CombinationBulkMap from '@pages/product/combination/bulk/combination-bulk-map'; | ||
| import FormFieldToggler from '@components/form/form-field-toggler'; | ||
|
|
||
| // @ts-ignore |
There was a problem hiding this comment.
I wonder if we can take this off. The @types/jquery library gives us the type
…ing they are both enabled/disabled at the same time
jolelievre
force-pushed
the
sync-combination-bulk-prices
branch
from
025a010 to
69449de
Compare
M0rgan01
approved these changes
Sep 27, 2023
matks
approved these changes
Sep 27, 2023
ps-jarvis
added
the
Waiting for QA
boherm
approved these changes
Sep 27, 2023
MhiriFaten
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Hello @jolelievre
The issue is well fixed and the bulk edit of prices is well working for product variants.
Untitled_.Sep.28.2023.9_03.AM.webm
Automated tests are OK ✔️
https://github.com/MhiriFaten/testing_pr/actions/runs/6335953118
Thank you.
MhiriFaten
added
QA ✔️
|
QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.