Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce css component for TypeaheadProductCollectionType #33760

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Introduce css component for TypeaheadProductCollectionType #33760

merged 1 commit into from
Aug 31, 2023

Conversation

PululuK
Copy link
Member

@PululuK PululuK commented Aug 29, 2023 •
edited
Loading

Questions Answers
Branch? develop
Description? When you implement multiple TypeaheadProductCollectionType, the selected products are not displayed correctly. This because we are using an ID instead of a class.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Make sure that BO product page related products field + seo replace product work well :).
Fixed issue or discussion? N/A
Related PRs N/A
Sponsor company Evolutive

@PululuK PululuK requested a review from a team as a code owner August 29, 2023 21:31
@prestonBot prestonBot added develop Branch Improvement Type: Improvement labels Aug 29, 2023
@PululuK PululuK changed the title introduce css component for TypeaheadProductCollectionType Introduce css component for TypeaheadProductCollectionType Aug 29, 2023
mflasquin
mflasquin approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mflasquin mflasquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Aug 30, 2023
florine2623
florine2623 approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @PululuK ,

Test auto OK : https://github.com/florine2623/testing_pr/actions/runs/6035062568/job/16376913414

Checked Product Page : related products field & SEO block.

LGTM ✅

@florine2623 florine2623 self-assigned this Aug 31, 2023
@florine2623 florine2623 added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 31, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@PululuK PululuK added this to the 9.0.0 milestone Aug 31, 2023
@mflasquin
Copy link
Contributor

Thanks @PululuK

@mflasquin mflasquin merged commit 6285d72 into PrestaShop:develop Aug 31, 2023
@PululuK PululuK deleted the introduce-css-component-_typeahead_product_collection_type branch August 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florine2623 florine2623 florine2623 approved these changes

@mflasquin mflasquin mflasquin approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees

@florine2623 florine2623

Labels
develop Branch Improvement Type: Improvement QA ✔️ Status: check done, code approved
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PululuK @prestonBot @mflasquin @matthieu-rolland @florine2623 @ps-jarvis