Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicates from smarty.config.inc.php #33555

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Remove duplicates from smarty.config.inc.php #33555

merged 3 commits into from
Aug 7, 2023

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Aug 7, 2023

Questions Answers
Branch? 8.1.x
Description? Removes duplicates and fixes order
Type? refacto
Category? CO
BC breaks? no
Deprecations? no
How to test? No need, just a refacto.
Fixed ticket? -
Related PRs #33136
Sponsor company -

@SharakPL SharakPL requested a review from a team as a code owner August 7, 2023 08:20
@prestonBot prestonBot added 8.1.x Branch Refactoring Type: Refactoring labels Aug 7, 2023
@SharakPL SharakPL added this to the 8.1.1 milestone Aug 7, 2023
@SharakPL SharakPL requested a review from kpodemski August 7, 2023 08:21
@kpodemski
Copy link
Contributor

Nice catch, thanks @SharakPL

Hlavtox
Hlavtox approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the methods one by one, no method removed, no method is duplicate.

Ping @Robin-Fischer-PS - can be merged without QA, if all test suites are green. 👍

@ps-jarvis ps-jarvis added the Waiting for QA Status: action required, waiting for test feedback label Aug 7, 2023
@Hlavtox Hlavtox modified the milestones: 8.1.1, 8.1.2 Aug 7, 2023
@SharakPL
Copy link
Contributor Author

SharakPL commented Aug 7, 2023

https://github.com/SharakPL/ga.tests.ui.pr/actions/runs/5782889212 tests fail on modules - don't know why, can't be related to this PR.

@Hlavtox
Copy link
Contributor

Hlavtox commented Aug 7, 2023

@SharakPL Not related, something is wrong with the module. 🤷

@SharakPL
Copy link
Contributor Author

SharakPL commented Aug 7, 2023

@SharakPL Not related, something is wrong with the module. 🤷

Then otherwise it's green

aniszr
aniszr approved these changes Aug 7, 2023
View reviewed changes
Copy link

@aniszr aniszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SharakPL

I tested your PR, and it's LGTM:heavy_check_mark:

Auto Test : https://github.com/aniszr/ga.tests.ui.pr/actions/runs/5786252887 ✔️

QA:heavy_check_mark:

Thanks!

@aniszr aniszr added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Aug 7, 2023
@Hlavtox Hlavtox merged commit b7c0ae1 into PrestaShop:8.1.x Aug 7, 2023
@SharakPL SharakPL deleted the smarty_config_patch branch August 7, 2023 16:43
@SharakPL SharakPL mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniszr aniszr aniszr approved these changes

@LouisAUTHIE LouisAUTHIE LouisAUTHIE approved these changes

@Hlavtox Hlavtox Hlavtox approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@aniszr aniszr

Labels
8.1.x Branch QA ✔️ Status: check done, code approved Refactoring Type: Refactoring
Projects
PR Dashboard
Archived in project
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@SharakPL @kpodemski @Hlavtox @LouisAUTHIE @aniszr @ps-jarvis @prestonBot