Add low_stock_threshold to fixtures #33491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hlavtox
commented
Jul 30, 2023
Hlavtox
commented
| Questions | Answers |
|---|---|
| Branch? | 8.1.x |
| Description? | Default demo data doesn't contain low_stock_threshold, which results in this value being NULL in the database, while in fact, it should be 0, like it is for all new products. |
| Type? | bug fix |
| Category? | IN |
| BC breaks? | no |
| Deprecations? | no |
| How to test? | Install Prestashop, open phpmyadmin, find ps_product and check that values in low_stock_threshold are zeroes, instead NULL for demo products. |
| Fixed ticket? | Fixes #33490 |
| Related PRs | |
| Sponsor company |
kpodemski
approved these changes
Jul 31, 2023
mflasquin
approved these changes
Jul 31, 2023
|
@mflasquin I think if it's not a BC break, we can target 8.1 no? |
|
8.1.x is a patch branch :
https://devdocs.prestashop-project.org/8/contribute/contribution-guidelines/supported-branches/ So regarding this page, you PR should target develop if I'm not mistaken |
|
@mflasquin this is outdated, we are more flexible regarding patch branches, updates guidelines will be available on the project's website |
|
@mflasquin more details: PrestaShop/docs#1682 |
mflasquin
added
the
Waiting for QA
hibatallahAouadni
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Hello @Hlavtox
Thanks for your PR 🚀
Without PR, the low_stock_threshold are NULL, see the attached screenshot below:
With your PR, the low_stock_threshold are zeroes ✔️
LGTM, QA ✔️
Thanks!
hibatallahAouadni
added
QA ✔️
|
Thank you Hiba! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.