Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete jquery-passy.LICENSE #31739

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Delete jquery-passy.LICENSE #31739

merged 1 commit into from
Mar 14, 2023

Conversation

leemyongpakvn
Copy link
Contributor

@leemyongpakvn leemyongpakvn commented Mar 12, 2023 •
edited by matks
Loading

Questions Answers
Branch? develop
Description? jquery-passy.js had been replaced by zxcvbn.js, and removed in #28127
So there is no need to keep its license there.
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
How to test? Automatic tests are enough.
Fixed ticket? Fixes #{issue number here}, Fixes #{another issue number here}
Related PRs If theme, autoupgrade or other module change is needed to make this change work, provide a link to related PRs here.
Sponsor company Your company or customer's name goes here (if applicable).

@leemyongpakvn
Delete jquery-passy.LICENSE
5f77713 
juqery-passy.js had been replaced by zxcvbn.js, and removed in PrestaShop#28127
@leemyongpakvn leemyongpakvn requested a review from a team as a code owner March 12, 2023 14:26
@prestonBot prestonBot added the Improvement Type: Improvement label Mar 12, 2023
@prestonBot prestonBot added the develop Branch label Mar 14, 2023
@matks matks added Waiting for QA Status: action required, waiting for test feedback and removed develop Branch labels Mar 14, 2023
@matks
Copy link
Contributor

matks commented Mar 14, 2023

Dear @PrestaShop/qa-team this change removes a useless file in installer (it's not used anymore since #28127) do you want to verify the installer works well? Or automatic tests are enough?

@hibatallahAouadni hibatallahAouadni added the Waiting for dev Status: action required, waiting for tech feedback label Mar 14, 2023
@FabienPapet FabienPapet added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Mar 14, 2023
@prestonBot
Copy link
Collaborator

QA approved, well done! Message to the maintainers: do not forget to milestone it before the merge.

@FabienPapet
Copy link
Member

Thank you @leemyongpakvn !

@FabienPapet FabienPapet merged commit 4f78450 into PrestaShop:develop Mar 14, 2023
@FabienPapet FabienPapet added this to the 9.0.0 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

@FabienPapet FabienPapet FabienPapet approved these changes

@nicosomb nicosomb nicosomb approved these changes

Assignees
No one assigned
Labels
Improvement Type: Improvement QA ✔️ Status: check done, code approved Waiting for dev Status: action required, waiting for tech feedback
Projects
PR Dashboard
Archived in project
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@leemyongpakvn @matks @prestonBot @FabienPapet @nicosomb @hibatallahAouadni