Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AniList): add buttons setting and fix user avatar #6784

Merged
merged 2 commits into from
Sep 16, 2022
Merged

feat(AniList): add buttons setting and fix user avatar #6784

merged 2 commits into from
Sep 16, 2022

Conversation

plskz
Copy link
Contributor

@plskz plskz commented Sep 13, 2022 •
edited
Loading

Description

  • add buttons in settings
  • fix /user avatar
  • fix /home - it was showing nothing (See screenshots)

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

image

buttons

with buttons

image

without buttons

image


page: /home and /user

Before

image

image

After

image

image

RisingSunLight42
RisingSunLight42 reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@RisingSunLight42 RisingSunLight42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to put settings checks at the bottom of the files. If the setting is not enabled, do a delete on the presenceData part concerned by the setting, e.g. :
if (!showButtons) delete presenceData.buttons;

@plskz
Copy link
Contributor Author

plskz commented Sep 13, 2022

peace

@EncryptedDev EncryptedDev requested a review from Bas950 September 15, 2022 21:07
@Bas950 Bas950 merged commit 9bf491f into PreMiD:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RisingSunLight42 RisingSunLight42 RisingSunLight42 left review comments

@EncryptedDev EncryptedDev EncryptedDev approved these changes

@Bas950 Bas950 Bas950 approved these changes

Assignees
No one assigned
Labels
activity update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plskz @Bas950 @EncryptedDev @RisingSunLight42