feat(Neko-sama): new presence #6740
Conversation
There was a problem hiding this comment.
Apply those first changes.
Other will come, since there's a lot of things related to the structure to changes, but I prefer to not review everything in one time for a better readability for you.
Also, don't forget to run prettier and use const when you're setting a variable that will not be changed. var is quite useless most of the time, so use let instead when you want to change the value inside a variable.
Don't hesitate to ask for help on Discord, in the presence-dev channel
|
Also, this needs a lang review in French. I'm french myself, but I'm not sure if I'm qualified enough to review the lang. |
Do I have to ask someone in particular for the French revision? |
@Kozou4ever can review it, if he has the time ^^ |
Okay, thank you :) |
If you make changes, just push your changes to your repository (Mokocchibi/Presences:main) and it will automatically appear in this PR. |
Okay, thanks! |
How can I do that ? |
Signed-off-by: Rhys Rakoff <64903135+EncryptedDev@users.noreply.github.com>
Done it myself |
Tu peux tenter ta chance :) |
J'ai demandé à un pote qui est super bon en grammaire, vocabulaire etc.. Et il a pas vu de problèmes |
There was a problem hiding this comment.
I have some more suggestions for you !
- Maybe convert your
if/else if/elsestatements to aswitch. You can see some examples on the repo, like here : https://github.com/PreMiD/Presences/blob/main/websites/T/Tellingtone/presence.ts - Also, when you're checking if the file is the default thumbnail. I can propose you to juste get the image, and at the end of the file, make a check like that :
if (presenceData.largeImageKey === "https://neko-sama.fr/images/default_thumbnail.png") presenceData.largeImageKey = "nekosama-icon"
It will be more readable and less repetitive ! ^^
Ça me semble nickel pour moi ! |
|
I made all the changes, is there something to review? |
|
What I have to do to finish this PR ? |
Wait for reviewers to approve it. |
|
Resolve conversations as you deal with them, can't approve until I see things have been dealt with properly. |
I made all suggered changes and reply to all so yes, I guess I have to wait as RisingSunLight42 said. |
You have not pressed the "Resolve conversation" button on the conversations... |
Hoo.. I'm sorry, didn't notice that. |
|
Infact, video playback no longer works with this modification :/ |
|
I made the changes but noticed that when the video wasn't playing the presence disappeared so I added an if to handle that and it worked at first but then the presence got stuck on an anime page and I don't know why :( |
Description
Adding presence for neko-sama.fr website.
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected