Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SOAP2DAY): change code structure and add setting #6690

Merged
merged 1 commit into from
Aug 23, 2022
Merged

refactor(SOAP2DAY): change code structure and add setting #6690

merged 1 commit into from
Aug 23, 2022

Conversation

RisingSunLight42
Copy link
Contributor

@RisingSunLight42 RisingSunLight42 commented Aug 22, 2022 •
edited
Loading

Description

Changelog

  • Resolves Show / Movie Title #6687 by adding a setting to display the name of the show/movie/etc currently viewed if enable (disabled by default !)
    Note : when the title of the show/movie/etc... is the same as the one in the video, it will be deleted from the presenceData.state.
  • Change code structure to avoid useless indent and lines
  • Remove some variables in consequence
  • Remove useless comment
  • Add myself as contributor

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

soap2day_proof_4

soap2day_proof_3

soap2day_proof_2

soap2day_proof_1

@EncryptedDev EncryptedDev enabled auto-merge (squash) August 22, 2022 21:48
@EncryptedDev EncryptedDev requested a review from Bas950 August 22, 2022 21:48
@EncryptedDev EncryptedDev merged commit d39b64f into PreMiD:main Aug 23, 2022
@RisingSunLight42 RisingSunLight42 deleted the refactor(SOAP2DAY) branch August 23, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EncryptedDev EncryptedDev EncryptedDev approved these changes

@Bas950 Bas950 Bas950 approved these changes

Assignees
No one assigned
Labels
activity update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show / Movie Title
3 participants
@RisingSunLight42 @Bas950 @EncryptedDev