refactor: improve types and fix errors #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Bas950 <me@bas950.com> Co-Authored-By: Rhys <64903135+EncryptedDev@users.noreply.github.com>
EncryptedDev
approved these changes
Dec 26, 2021
Bas950
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request:
This PR fixes a regression introduced in #5131 that made it so some presences no longer compiled. Also took the chance to improve the typings and add a generic type argument to getPageletiable thanks to @Bas950. Also changed the type for the event listeners so you are now required to return void or Promise and also cast the type of the parameter in the iFrameData event. All versions were bumped with patch, except for Apple which got a minor bump due to the addition of the multiLanguage setting
Proof to proving the creation/modification working