Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Types): allow passing of type in getSetting #5131

Merged
merged 1 commit into from
Dec 26, 2021
Merged

feat(Types): allow passing of type in getSetting #5131

merged 1 commit into from
Dec 26, 2021

Conversation

Bas950
Copy link
Member

@Bas950 Bas950 commented Dec 26, 2021 •
edited
Loading

Describe the changes in this pull request:

Proof to proving the creation/modification working

@Bas950 @Timeraa
feat(Types): allow passing of type in getSetting
4205c7b 
Co-Authored-By: Florian Metz <me@timeraa.dev>
@Bas950 Bas950 requested a review from Timeraa as a code owner December 26, 2021 11:46
@Bas950 Bas950 enabled auto-merge (squash) December 26, 2021 11:47
@Bas950 Bas950 merged commit 893ba6d into PreMiD:main Dec 26, 2021
@Bas950 Bas950 deleted the Allow-Type-getSetting branch December 26, 2021 11:49
@ImRodry ImRodry mentioned this pull request Dec 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slowlife01 Slowlife01 Slowlife01 approved these changes

@Timeraa Timeraa Timeraa approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bas950 @Timeraa @Slowlife01