Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Presence: ZombsRoyale.io #3786

Merged
merged 6 commits into from
May 23, 2021
Merged

New Presence: ZombsRoyale.io #3786

merged 6 commits into from
May 23, 2021

Conversation

MrBartusek
Copy link
Contributor

@MrBartusek MrBartusek commented May 21, 2021 •
edited
Loading

Fixes: #3680

image
image
image

@MrBartusek
Copy link
Contributor Author

False-positive from codacy

@MrBartusek @rxri
Update websites/Z/ZombsRoyale.io/presence.ts
7d08c14 
Co-authored-by: ririxidev <mail@ririxi.dev>
Bas950
Bas950 previously approved these changes May 21, 2021
View reviewed changes
rxri
rxri suggested changes May 22, 2021
View reviewed changes
Copy link
Contributor

@rxri rxri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there more to show instead of only viewing, buying etc? also check type in ifs too
== -> ===

@MrBartusek
Copy link
Contributor Author

MrBartusek commented May 22, 2021 •
edited
Loading

isn't there more to show instead of only viewing, buying etc?

I searched a bit but it seems like there isn't anything else that game.currentGameState

rxri
rxri suggested changes May 22, 2021
View reviewed changes
Copy link
Contributor

@rxri rxri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and run prettier over it

websites/Z/ZombsRoyale.io/presence.ts Outdated Show resolved Hide resolved
websites/Z/ZombsRoyale.io/presence.ts Outdated Show resolved Hide resolved
websites/Z/ZombsRoyale.io/presence.ts Outdated Show resolved Hide resolved
MrBartusek and others added 3 commits May 22, 2021 14:00
@MrBartusek @rxri
Update websites/Z/ZombsRoyale.io/presence.ts
6f7fac3 
Co-authored-by: ririxidev <mail@ririxi.dev>
@MrBartusek @rxri
Update websites/Z/ZombsRoyale.io/presence.ts
648ff6f 
Co-authored-by: ririxidev <mail@ririxi.dev>
@MrBartusek
Run Prettifier
12126e9
@MrBartusek MrBartusek requested review from rxri and Bas950 May 22, 2021 12:24
@rxri rxri enabled auto-merge (squash) May 23, 2021 07:55
@rxri rxri merged commit fb20867 into PreMiD:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bas950 Bas950 Bas950 approved these changes

@rxri rxri rxri approved these changes

@StrikerFRFX StrikerFRFX Awaiting requested review from StrikerFRFX

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zombs Royale | zombsroyale.io
3 participants
@MrBartusek @rxri @Bas950